GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — fix(notion): align integration with live API docs, add block retrieval coverage by waleedlatif1 · Pull Request #5491 · simstudioai/sim Conversation
Collaborator
Summary
Type of Change
TestingTested manually — validated every tool against live Notion API docs, ran full validate-integration checklist (tool params, block↔tool alignment, conditions, outputs, OAuth scopes). Checklist
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…l coverage
- wire up notion_update_page in the block (was registered but unreachable — no dropdown option or subBlocks)
- fix legacy NotionBlock outputs to cover all 17 operations, not just content/metadata
- trim ID params (pageId, databaseId, parentId) before use in request URLs across 8 tool files
- remove content required:true on create_page (Notion allows title-only pages)
- remove dead unused NotionReadDatabaseParams interface
- add notion_retrieve_block/_v2 tool for GET /v1/blocks/{id}, filling a gap in block CRUD coverage
|
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
PR SummaryMedium Risk Overview New and exposed capabilities: Adds Reliability and UX fixes: Notion IDs used in request URLs are Cleanup: Removes dead/unused type helpers in Reviewed by Cursor Bugbot for commit 040d6e7. Configure here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR closes a set of alignment gaps between the Notion integration's UI, tool registry, and live API docs:
Confidence Score: 5/5Safe to merge — changes are additive fixes to the Notion integration with no breaking API surface changes. All changes are additive: new tools, new output conditions, and whitespace guards. The legacy block and V2 block are both correctly wired, the tool registry is updated, and the V2 versioned-selector pattern is followed consistently. The only finding is a documentation inaccuracy in the newly added docs section that does not affect runtime behavior. apps/docs/content/docs/en/integrations/notion.mdx — the notion_retrieve_block output table lists all shared outputs rather than just what the tool returns. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User selects operation in Notion Block] --> B{Block version?}
B -- Legacy NotionBlock --> C[getTool switch → notion_retrieve_block]
B -- NotionV2Block --> D[createVersionedToolSelector\n operation + '_v2'\n → notion_retrieve_block_v2]
C --> E[notionRetrieveBlockTool\nGET /v1/blocks/blockId.trim]
D --> F[notionRetrieveBlockV2Tool\nshares request + transformResponse]
E --> G[transformResponse\nsuccess: response.ok\noutput: id, type, has_children,\narchived, block]
F --> G
G --> H[Block outputs conditioned on\n'notion_retrieve_block'\nid · type · has_children\narchived · block]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User selects operation in Notion Block] --> B{Block version?}
B -- Legacy NotionBlock --> C[getTool switch → notion_retrieve_block]
B -- NotionV2Block --> D[createVersionedToolSelector\n operation + '_v2'\n → notion_retrieve_block_v2]
C --> E[notionRetrieveBlockTool\nGET /v1/blocks/blockId.trim]
D --> F[notionRetrieveBlockV2Tool\nshares request + transformResponse]
E --> G[transformResponse\nsuccess: response.ok\noutput: id, type, has_children,\narchived, block]
F --> G
G --> H[Block outputs conditioned on\n'notion_retrieve_block'\nid · type · has_children\narchived · block]
Reviews (4): Last reviewed commit: "fix(notion): document type-specific cont..." | Re-trigger Greptile |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…s, dead types, regen docs - add missing startCursor/start_cursor pagination param to notion_query_database and notion_search - fix notion_search missing from the shared pageSize/startCursor field's operation condition in NotionBlock - fix NotionV2Block title/url/created_time/last_edited_time outputs rendering unconditionally for every operation instead of only the ones that return them - remove 153 lines of dead unused output-shape constants from types.ts - regenerate integration docs
type/block/archived only conditioned on notion_update_block/notion_delete_block, and has_children was missing entirely — Retrieve Block's payload was invisible in the legacy NotionBlock output picker (Greptile P1 on PR #5491).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 98cc1ef. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
block.properties (BLOCK_OUTPUT_PROPERTIES) only covers common block fields, not the type-specific sub-object (paragraph.rich_text, image.file, etc.) — that varies per block type and isn't enumerable. Documented in the description per Greptile P2 on PR #5491; no functional change, block: data already carries the full object at runtime.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@cursor review |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 040d6e7. Configure here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
040d6e76
Deployed
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.