GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — improvement(files): match CSV/XLSX preview tables to the markdown table chrome by waleedlatif1 · Pull Request #6125 · simstudioai/sim

Conversation

waleedlatif1 commented Jul 31, 2026

Copy link

Copy Markdown

Collaborator

Summary

Tables in the file viewer looked different depending on the file — CSV/XLSX previews had their own chrome (rounded outer frame, --surface-2 header, 13px body / 12px header, --text-secondary cells) while markdown files rendered tables through the rich markdown editor (full cell borders on --divider, --surface-4 header, 14px text)
Extracted the markdown table chrome into a shared document-table.css and styled both surfaces from it; removed the custom DataTable styling
The editor stylesheet keeps only its own concerns (table-layout: fixed for column resizing, prose block margin, cell paragraph reset); DataTable keeps only its edit affordances
Added a jsdom test that loads the real shipped CSS and asserts the two surfaces resolve to the same cell padding/typography and are bordered/filled by one rule, so they can't drift again

Type of Change

Bug fix

Testing

vitest file-viewer suite (575 tests) + typecheck green. New parity test verified to fail when the shared rule drops the prose selector, and when the editor stylesheet re-declares cell chrome.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction


          improvement(files): match CSV/XLSX preview tables to the markdown tab…

a79b9db

…le chrome

Tables in the file viewer looked different depending on the file: CSV and XLSX previews rendered their own chrome (rounded outer frame, --surface-2 header, 13px body / 12px header, --text-secondary cells) while markdown files rendered tables through the rich markdown editor (full cell borders on --divider, --surface-4 header, 14px text).

Extract the markdown table chrome into document-table.css and style both surfaces from it. The editor stylesheet keeps only its own concerns (fixed layout for column resizing, prose block margin, cell paragraph reset); DataTable keeps only its edit affordances.

vercel Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 31, 2026 7:22pm

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

PR Summary

Low Risk
Presentation-only CSS consolidation in the file viewer with parity tests; no auth, data, or API changes.

Overview
CSV/XLSX previews and markdown tables in the file viewer now share one table look instead of divergent styling (preview-specific frame, smaller text, different header/cell colors).

Shared chrome lives in new document-table.css, imported by DataTable and the rich markdown editor. Duplicate table rules were removed from rich-markdown-editor.css; the editor keeps only table-specific behavior (table-layout: fixed, margins, cell paragraph reset). DataTable drops most Tailwind table styling and only adds edit hover/ring classes.

Regression guard: document-table.test.ts loads the real CSS and checks computed padding/typography parity plus a single shared rule for borders and header fill.

^{Reviewed by Cursor Bugbot for commit 3089ea8. Configure here.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot reviewed

Jul 31, 2026

View reviewed changes

Comment thread

apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/document-table.css Resolved

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Greptile Summary

Consolidates CSV, XLSX, and markdown table presentation into shared styling.

Adds a common document-table.css stylesheet for cell borders, spacing, typography, wrapping, and header fill.
Removes duplicated table chrome from the data-table component and markdown-editor stylesheet while retaining surface-specific behavior.
Adds CSS parity tests covering both rendering surfaces.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/data-table.tsx	Replaces preview-specific table utility classes with shared document-table styling while retaining edit affordances.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/document-table.css	Defines the shared table chrome used by CSV, XLSX, and rich-markdown surfaces.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/document-table.test.ts	Verifies that both table surfaces resolve to the same typography, spacing, wrapping, borders, and header fill.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.css	Removes duplicated table chrome while retaining editor-specific layout and prose rules.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.tsx	Loads the shared table stylesheet before editor-specific styling.
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-field.tsx	Loads the shared table stylesheet for standalone rich-markdown fields.

_{Reviews (2): Last reviewed commit: "fix(files): wrap unbreakable cell values..." | Re-trigger Greptile}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          fix(files): wrap unbreakable cell values in preview tables like markd…

3089ea8

…own does

The markdown prose root sets overflow-wrap: anywhere; the preview root did not, so with whitespace-nowrap gone a long URL or hash in a CSV cell would overflow instead of breaking.

vercel Bot temporarily deployed to Preview

July 31, 2026 19:22

Inactive

waleedlatif1 commented Jul 31, 2026

Copy link

Copy Markdown

Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

waleedlatif1 commented Jul 31, 2026

Copy link

Copy Markdown

Collaborator Author

@cursor review

cursor[bot] reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot reviewed

Jul 31, 2026

View reviewed changes

cursor Bot left a comment

Copy link

Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 3089ea8. Configure here.}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

waleedlatif1 merged commit 898a10d into staging

Jul 31, 2026

27 checks passed

Uh oh!

There was an error while loading. Please reload this page.

waleedlatif1 deleted the worktree-csv-table-md-chrome branch

July 31, 2026 19:27

waleedlatif1 mentioned this pull request

Aug 1, 2026

v0.7.51: hybrid search for knowledgebases, ui improvements, db perf improvements, claude managed agents tools, realtime files and tables #6146

Merged

waleedlatif1 mentioned this pull request

Aug 11, 2026

fix(files): restore horizontal scroll in CSV and XLSX preview tables #6550

Merged

6 tasks done

waleedlatif1 added a commit that referenced this pull request

Aug 11, 2026


          fix(files): restore horizontal scroll in CSV and XLSX preview tables (#…

bd91ab7

…6550)

* fix(files): restore horizontal scroll in CSV and XLSX preview tables

#6125 moved the preview tables onto the markdown table chrome and gave both
surfaces `width: 100%`. That is right for prose and wrong for data: a CSV with
dozens of columns divides the frame between them, and since the same change
added `overflow-wrap: anywhere`, every column was free to break down to a single
character — so headers rendered as vertical columns of letters and the table
never exceeded its frame, leaving `overflow-x-auto` with nothing to scroll.

Split sizing out of the shared rule. Prose tables keep `width: 100%`; preview
tables size to their content and scroll, with column bounds so no column
collapses to a sliver and one long value wraps instead of pushing the rest
off-screen. Chrome (borders, padding, typography, header fill) stays shared.

* fix(files): scroll preview tables from one container, not two nested ones

DataTable owned `overflow-x-auto` while its caller owns the vertical scroll, so
now that preview tables are actually wider than the frame the horizontal
scrollbar rendered at the foot of the table rather than at the bottom of the
viewport — up to 1,000 rows below it for the two callers whose container is a
plain block (xlsx-preview, preview-panel). csv-table-preview escaped it only
because its flex column compressed the wrapper to the frame height.

Drop the inner overflow so the caller's bounded container scrolls both axes.
All three callers now place the scrollbar at the viewport bottom.

* fix(files): correct a stale reference to the removed inner overflow

The sizing comment still credited `.document-table`'s own `overflow-x-auto`
for the horizontal scroll, which the previous commit removed in favour of the
caller's container.

This branch was previously deployed

1 inactive deployment

Preview — 3089ea87 Deployed Jul 31, 2026 by vercel[bot]

View deployment

Reviewers

cursor[bot]

cursor[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

waleedlatif1 commented Jul 31, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

waleedlatif1 commented Jul 31, 2026

Uh oh!

waleedlatif1 commented Jul 31, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

cursor Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps Bot commented Jul 31, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.