GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(api-keys): remove the api-key-read-only flag by waleedlatif1 · Pull Request #9879 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

Read-only API keys (#9855) are live: every production app pod runs v0.9.53, which enforces key access, and api-key-read-only is on in production AppConfig (feature-flags v45). This removes the flag so read-only key creation is always available.

  • Drop the flag from the registry, its API_KEY_READ_ONLY fallback env, and lib/api-key/feature-flag.ts
  • The create use case no longer checks the flag (resolveIssueSettings is now synchronous)
  • The create-key modal always offers Access, except where a key must be full access (deploy modal, workflow MCP server)
  • Remove the flag from the workspace, organization and account layouts and from WorkspaceFeatureFlags
  • Remove the flag-off integration test and the account layout test that only covered passing the flag through
  • Docs: drop the caveat that Access may be hidden because read-only keys aren't available yet

Enforcement of read-only keys never depended on the flag, so this changes nothing for existing keys.

Rollout

After this ships to production, remove api-key-read-only from the prod feature-flags AppConfig document. Self-hosted deployments get read-only keys on upgrade. Rolling back below v0.9.53 still requires revoking read-only keys first, since older code serves them as full access.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waleedlatif1
chore(api-keys): remove the api-key-read-only flag now that read-only…
1ae4d77 
… keys are live

Every production pod runs v0.9.53, which enforces key access, and the flag is on in prod AppConfig. Read-only key creation is now always available: the create modal always offers Access (except where a key must be full access), and the create use case no longer consults the flag.
@vercel

vercel Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 11, 2026 5:48pm UTC

Request Review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 11, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Removes the rollout flag so read-only API keys are always available.

  • People can create read-only API keys without a rollout flag.

Known limitation acknowledged by waleedlatif1: rolling back below v0.9.53 requires revoking read-only keys first, because older releases treat them as full access.

Reviews (1) · Last reviewed commit: "chore(api-keys): remove the api-key-read..." · Reviewed by Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 merged commit abc5ead into staging Nov 11, 2026
59 of 61 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 deleted the chore/remove-api-key-read-only-flag branch November 11, 2026 17:46
@vercel
vercel Bot deployed to Preview November 11, 2026 17:48
View deployment
waleedlatif1 added a commit that referenced this pull request Nov 11, 2026
@waleedlatif1
Merge origin/staging (#9879) into improvement/platform-core-chat
5750458 
Removes the api-key-read-only flag from the Platform surface too: the
surface contract, organization surface resolver, the read-only key hook,
and both create-key modals now always offer read-only access.
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 12, 2026
v0.9.54: non-OAuth auth for twelve more integrations, agent API additions (workflow outline, schedules list, paused runs, scoped CLI pairing keys), concurrent-edit guard, dependency updates #9912
Merged

This branch was successfully deployed

1 active deployment
Preview — 1ae4d77e Deployed Nov 11, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.