GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — a8n: add branch flag for creating campaigns by kzh · Pull Request #96 · sourcegraph/src-cli

Conversation

@kzh

@kzh kzh commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

This PR adds a flag to specify a branch name when creating campaigns.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kzh
a8n: add branch flag for creating campaigns
4ed7182
@kzh
kzh requested a review from mrnugget January 29, 2020 14:47
@mrnugget

mrnugget commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

Idea as suggested by @sqs in https://github.com/sourcegraph/sourcegraph/issues/7850#issuecomment-577674931:

It would be cool if the branch name could also be specified in the Markdown file by using a comment, such as:

Title of the campaign

Description

// branch = my-branch-name

There's precedent here: sometimes blog engines or static site generators allow you to add "front matter" to a page, in the form of YAML/TOML/JSON (see Hugo's explanation of it here: https://gohugo.io/content-management/front-matter/)

I don't think we need to fully support that, but some way to declare a line as "meta" would be great.
kzh reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mrnugget mrnugget mentioned this pull request Jan 30, 2020
a8n/web: Allow users to specify branch name before Campaign creation and provide great default value sourcegraph/sourcegraph-public-snapshot#7646
Closed
@kzh kzh mentioned this pull request Feb 3, 2020
Core Services: 3.13 Tracking Issue sourcegraph/sourcegraph-public-snapshot#7719
Closed
58 of 81 tasks
@mrnugget

mrnugget commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Update on my previous comment here: it's more important to get this merged with the basic functionality (-branch flag!) than the additonal functionality of specifying the branch name in the markdown file.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kzh
kzh marked this pull request as ready for review February 5, 2020 09:33
@kzh
Add condition for manual campaigns
7acad7a
@kzh
kzh force-pushed the kz/a8n-campaign-branch branch from 19ba1bc to 7acad7a Compare February 5, 2020 09:37
mrnugget
mrnugget approved these changes Feb 5, 2020
View reviewed changes
@mrnugget
Document branch option in help output and friendly format message
492cdb1
@mrnugget

mrnugget commented Feb 13, 2020

Copy link
Copy Markdown
Contributor

Merging this now since https://github.com/sourcegraph/sourcegraph/pull/8111 has been merged.

I also added a commit that documents this new flag and prints it in the friendly output message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mrnugget
mrnugget merged commit 52c5f0e into master Feb 13, 2020
scjohns pushed a commit that referenced this pull request Apr 24, 2023
@kzh @mrnugget
a8n: add branch flag for creating campaigns (#96)
37fca34 
* a8n: add branch flag for creating campaigns

* Add condition for manual campaigns

* Document branch option in help output and friendly format message

Co-authored-by: Thorsten Ball <[email protected]>
@keegancsmith
keegancsmith deleted the kz/a8n-campaign-branch branch November 11, 2025 20:52
@marcleblanc2 marcleblanc2 mentioned this pull request Oct 30, 2026
chore/deps: patch Trivy and Dependabot findings preparing for release #1383
Merged
marcleblanc2 added a commit that referenced this pull request Nov 3, 2026
@marcleblanc2 @ampagent
chore/deps: patch Trivy and Dependabot findings preparing for release (…
d613971 
…#1383)

* chore/deps: patch all open Trivy and Dependabot findings

Bump golang.org/x/{crypto,net,text,mod}, github.com/klauspost/compress,
github.com/go-jose/go-jose/v4, google.golang.org/grpc, and
go.opentelemetry.io/otel/sdk in go.mod and lib/go.mod so that
`trivy fs --severity HIGH,CRITICAL` is clean and Dependabot alerts
#91-#96 close. No code changes.

* chore/renovate: fix invalid JSON in renovate.json

A doubled comma after the "$schema" key made renovate.json unparseable,
so Renovate stopped opening PRs for this repository.

Fixes #1345

* snapshot upload: use option.WithAuthCredentialsFile

google.golang.org/api v0.264.0 deprecates option.WithCredentialsFile
(staticcheck SA1019), which failed the go-lint job. The credentials file
is a service account key, so load it as that type explicitly.

Amp-Thread-ID: https://ampcode.com/threads/T-01a18b16-df86-7399-a300-979289761a30
Co-authored-by: Amp <[email protected]>

---------

Co-authored-by: Amp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mrnugget mrnugget mrnugget approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kzh @mrnugget
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.