GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: switch off vectorize cockroachdb by bajinsheng · Pull Request #659 · sqlancer/sqlancer

Conversation

@bajinsheng

@bajinsheng bajinsheng commented Dec 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

The vectorize option is on by default: https://www.cockroachlabs.com/docs/v22.2/vectorized-execution#configure-vectorized-execution so we are required to randomly switch it off here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bajinsheng
bajinsheng requested a review from mrigger December 18, 2022 08:19
@bajinsheng bajinsheng mentioned this pull request Dec 18, 2022
Support QPG #641
Closed
@bajinsheng
bajinsheng enabled auto-merge (squash) December 18, 2022 08:20
mrigger
mrigger reviewed Dec 18, 2022
View reviewed changes

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since vectorization is on by default, perhaps we can just remove the option to make vectorization more likely and the code here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mrigger

mrigger commented Dec 18, 2022

Copy link
Copy Markdown
Contributor

https://github.com/sqlancer/sqlancer/blob/master/src/sqlancer/cockroachdb/gen/CockroachDBSetSessionGenerator.java also randomly turns vectorization off.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bajinsheng

bajinsheng commented Dec 18, 2022

Copy link
Copy Markdown
Collaborator Author

https://github.com/sqlancer/sqlancer/blob/master/src/sqlancer/cockroachdb/gen/CockroachDBSetSessionGenerator.java also randomly turns vectorization off.

So we fully remove this switch here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bajinsheng
fix: remove redundant vectorization cockroachdb
9fcb31b
@bajinsheng
bajinsheng requested a review from mrigger December 18, 2022 08:34
@mrigger
mrigger removed their request for review December 18, 2022 08:43
mrigger
mrigger approved these changes Dec 18, 2022
View reviewed changes
@bajinsheng
bajinsheng merged commit 00cda2e into sqlancer:master Dec 18, 2022
albertZhangTJ pushed a commit to albertZhangTJ/sqlancer-lancerfuzz that referenced this pull request Dec 19, 2022
Jinsheng Ba @albertZhangTJ
fix: switch off vectorization cockroachdb (sqlancer#659)
aa2bd7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrigger mrigger mrigger approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bajinsheng @mrigger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.