GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve nullability evaluation by lorenz · Pull Request #2858 · sqlc-dev/sqlc

Conversation

@lorenz

@lorenz lorenz commented Oct 15, 2023

Copy link
Copy Markdown

This now supports evaluating nullability if subqueries, function-defined tables or sqlc.embed macros are involved.
If nullable embeds are generated, this now errors out instead of emitting code which breaks at runtime.

Generating correct type definitions for that case would be easy, but scanning data into embed pointers is hard as it would require "peeking" at row nullability to decide if the type should be allocated and scanned into. Otherwise the null columns need to be directed into some kind of sink. Because this is nontrivial to do this is not part of this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

m-baertschi, hendrikhofstadt, dbachhh, ahobsonsayers, cyclimse, LeoRiether, abh, and PudottaPommin reacted with thumbs up emoji cyclimse, jchen42703, eberkund, theadell, PudottaPommin, and hu3bi reacted with heart emoji
All reactions
  • 👍 8 reactions
  • ❤️ 6 reactions
@lorenz
Improve nullability evaluation
698c471
This now supports evaluating nullability if subqueries, function-defined
tables or sqlc.embed macros are involved.
If nullable embeds are generated, this now errors out instead of
emitting code which breaks at runtime.

Generating correct type definitions for that case would be easy, but
scanning data into embed pointers is hard as it would require "peeking"
at row nullability to decide if the type should be allocated and scanned
into. Otherwise the null columns need to be directed into some kind
of sink. Because this is nontrivial to do this is not part of this PR.
@brasic brasic mentioned this pull request Dec 5, 2023
sqlc.embed using LEFT JOIN #2997
Open
@jaredweinfurtner

jaredweinfurtner commented Mar 10, 2026

Copy link
Copy Markdown

@lorenz FYI you still have conflicts if you wanted to follow up on it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kyleconroy Claude

kyleconroy commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

🤖 Automated message

This PR has been closed because it has merge conflicts with main. To reopen it, rebase onto the latest main to resolve the conflicts, then reopen the PR.


Generated by Claude Code

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kyleconroy kyleconroy closed this Jun 8, 2026
@meem3443 meem3443 mentioned this pull request Nov 6, 2026
fix(compiler): reject sqlc.embed on the nullable side of an outer join #4679
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lorenz @jaredweinfurtner @kyleconroy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.