GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(compiler): reject sqlc.embed on the nullable side of an outer join by meem3443 · Pull Request #4679 · sqlc-dev/sqlc ConversationUpdates #2997.
Plain columns are already made nullable by The join rules are the same as for plain columns (LEFT, RIGHT, FULL). This only turns the runtime failure into a generate-time error, as #2858 did. A real fix needs a design choice (#2348). It is a breaking change for queries that work today because they never hit a missing row. Limits:
TestNew end-to-end cases
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsAn embedded struct is the model of its table, whose columns may not be nullable. When the table is on the nullable side of a LEFT, RIGHT or FULL JOIN the query returns NULLs the struct cannot hold, so the generated code compiled but failed at runtime with "converting NULL to string is unsupported". Report an error at generate time instead. The join walk is the one that already makes plain columns nullable (isTableRequired); embeds skipped it because their column carries no table. Only the top-level FROM clause is checked, as for plain columns. The error is returned together with the columns. A database analyzer discards inference errors and replaces the columns when none come back, which would have turned the embed into flat columns. Updates sqlc-dev#2997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |