GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(debug): Add databases=managed debug option by kyleconroy · Pull Request #2898 · sqlc-dev/sqlc

Conversation

@kyleconroy

@kyleconroy kyleconroy commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator
  • Remove the --no-database flag
  • Refactor the shfmt package

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kyleconroy
feat(debug): Add databases=managed debug option
472c9b3 
- Remove the --no-database flag
- Refactor the shfmt package
@kyleconroy
kyleconroy requested a review from andrewmbenton October 21, 2023 00:42
andrewmbenton
andrewmbenton suggested changes Oct 21, 2023
View reviewed changes
Comment thread internal/engine/postgresql/analyzer/analyze.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread internal/cmd/vet.go Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread internal/cmd/vet.go
@@ -448,14 +448,7 @@ func (c *checker) fetchDatabaseUri(ctx context.Context, s config.SQL) (string, f
}

func (c *checker) DSN(dsn string) (string, error) {

@andrewmbenton andrewmbenton Oct 21, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really need this func anymore

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@kyleconroy kyleconroy Oct 21, 2023

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but it was easier to keep it around

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kyleconroy and others added 2 commits October 20, 2023 23:31
@kyleconroy @andrewmbenton
Update vet.go
5e9be80 
Co-authored-by: Andrew Benton <[email protected]>
@kyleconroy @andrewmbenton
Update analyze.go
e6e1107 
Co-authored-by: Andrew Benton <[email protected]>
andrewmbenton
andrewmbenton approved these changes Oct 21, 2023
View reviewed changes
@kyleconroy
kyleconroy merged commit df4c05b into main Oct 23, 2023
@kyleconroy
kyleconroy deleted the kyle/sqlcdebug-databases branch October 23, 2023 17:02
@p-linnane p-linnane mentioned this pull request Oct 24, 2023
sqlc 1.23.0 Homebrew/homebrew-core#152306
Merged
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@kyleconroy @andrewmbenton
feat(debug): Add databases=managed debug option (sqlc-dev#2898)
dae1f2a 
* feat(debug): Add databases=managed debug option

- Remove the --no-database flag
- Refactor the shfmt package

---------

Co-authored-by: Andrew Benton <[email protected]>
@shaikn6 shaikn6 mentioned this pull request Sep 4, 2026
docs: document SQLCDEBUG=databases=managed #4607
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@andrewmbenton andrewmbenton andrewmbenton approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kyleconroy @andrewmbenton
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.