Description

datvm

opened on Aug 25, 2020

Issue body actions

Details for the issue

What did you do?

On Windows, we have this useful option that move the mouse to a dialog button:

However, with (not too) recent update, whenever I browse a column with a foreign key, DB would try to load the data of that table to make it into a select combo-box. That's fine by me although I am not using that feature but during the loading, a dialog box is shown and so my mouse is moved there, which is quite disruptive.

What did you expect to see?

The dialog should not show up, or should not have any button. I think there should be an option to either disable the loading dialog, or at least disable the feature completely if I do not need it.

What did you see instead?

My mouse is moved to an invisible button (maybe because I can never see it, it's too quickly).

Useful extra information

The info below often helps, please fill it out if you're able to. :)

What operating system are you using?

• Windows: ( version: 10 )
• Linux: ( distro: ___ )
• macOS: ( version: ___ )
• Other: ___

What is your DB4S version?

• 3.12.0
• 3.11.x
• Other: 3.12.99 (Aug 25 2020 nightly build) but can confirm it happens since the latest stable build.

Did you also

• Try out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
• Search for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

Activity

1. chrisjlocke commented on Aug 25, 2020

   

   chrisjlocke

   on Aug 25, 2020

   Member

   More actions

   I believe the dialog is a 'please wait while data is being loaded' alert. I believe it may have a cancel button, which may be throwing off your mouse 'ping to a button' feature...
   If you do load a large table, that dialog would need to pop up, so it would be hard to disable it completely. We could wrap some 'if we've only taken a second, don't show the dialog, but its been three seconds now, so lets pop up a dialog' but that could be a fair bit of code, compared to the 'quick-n-dirty' way we're using at the moment....
2. datvm commented on Aug 26, 2020

   

   datvm

   on Aug 26, 2020

   Author

   More actions

   Thanks for the response!

   In WinForm/WPF, we could set the button as non-primary (i.e not default button). The mouse cursor wouldn't be moved if it is so. Is it possible for Qt? Or can I disable the whole feature?
3. mgrojo

   self-assigned this

   on Aug 28, 2020
4. mgrojo commented on Aug 28, 2020

   

   mgrojo

   on Aug 28, 2020

   Member

   More actions

   We are using QProgressDialog. I've tried to set a cancel button without the default and autoDefault properties but I've seen no difference in Linux. It still looks as a default button and pressing Space bar cancels the progress, so maybe the dialog is forcing the property. Should I commit it nevertheless to try it in Windows?
5. justinclift commented on Aug 28, 2020

   

   justinclift

   on Aug 28, 2020

   Member

   More actions

   Should I commit it nevertheless to try it in Windows?

   Might as well try it. 😄
6. mgrojo

   added 2 commits that reference this issue on Aug 29, 2020

   Remove the Default property of the fetching dialog

   36fabc0

   Remove the Default property of the fetching dialog

   c791a9f
7. mgrojo commented on Aug 30, 2020

   

   mgrojo

   on Aug 30, 2020

   Member

   More actions

   Confirmed as working in PR #2386.

   Reacted by Justin Clift
8. mgrojo

   closed this as completedon Aug 30, 2020
9. mgrojo

   added this to the 3.12.1 milestone on Aug 30, 2020
10. mgrojo

    added

    gui

    needs merging with upcoming release branch

    on Aug 30, 2020
11. mgrojo

    removed

    needs merging with upcoming release branch

    on Sep 13, 2020
12. mgrojo

    added a commit that references this issue on Sep 14, 2020

    Remove the Default property of the fetching dialog

    3c920ba

Issue actions