GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove the Default property of the fetching dialog by mgrojo · Pull Request #2386 · sqlitebrowser/sqlitebrowser

Conversation

@mgrojo

@mgrojo mgrojo commented Aug 29, 2020

Copy link
Copy Markdown
Member

Remove the default and auto-default properties of the cancel button in the
"Fetching data..." dialog.

See issue #2383

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mgrojo
Remove the Default property of the fetching dialog
36fabc0 
Remove the default and auto-default properties of the cancel button in the
"Fetching data..." dialog.

See issue #2383
@mgrojo
mgrojo requested a review from justinclift August 29, 2020 15:00
@mgrojo

mgrojo commented Aug 29, 2020

Copy link
Copy Markdown
Member Author

@justinclift Do you mind launching a Windows build so @datvm can test whether #2383 is solved before merging this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mgrojo
mgrojo marked this pull request as draft August 29, 2020 15:02
@justinclift

justinclift commented Aug 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

No worries. Win64 build is here. 😄

  • https://nightlies.sqlitebrowser.org/win64-onceoffs/DB.Browser.for.SQLite-pr_2386_v1-win64.msi
  • https://nightlies.sqlitebrowser.org/win64-onceoffs/DB.Browser.for.SQLite-pr_2386_v1-win64.zip

Can do a Win32 one as well, if that'd be useful
mgrojo and datvm reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@datvm

datvm commented Aug 30, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Hi, just tested @justinclift 's zip file, can confirm the mouse cursor no longer moves to the dialog.

P.s: probably unrelated but an old message box reappears in this build. I think just because you haven't merged the fix yet but still notify you just in case:

image
justinclift and mgrojo reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mgrojo
mgrojo marked this pull request as ready for review August 30, 2020 22:06
@mgrojo
mgrojo merged commit c791a9f into master Aug 30, 2020
@mgrojo

mgrojo commented Aug 30, 2020

Copy link
Copy Markdown
Member Author

Thanks @datvm. It's already merged. The message is already fixed in the master branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mgrojo
mgrojo deleted the issue_2383 branch August 30, 2020 22:10
@mgrojo mgrojo mentioned this pull request Aug 30, 2020
Loading dialog takes over mouse position on Windows with Auto Move option on #2383
Closed
4 of 9 tasks
@mgrojo
mgrojo restored the issue_2383 branch October 14, 2023 21:27
@mgrojo
mgrojo deleted the issue_2383 branch October 14, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinclift justinclift Awaiting requested review from justinclift

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mgrojo @justinclift @datvm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.