GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Workaround for WindowsVista style (qwindowsvistastyle plugin) by sandman7920 · Pull Request #2741 · sqlitebrowser/sqlitebrowser

Conversation

@sandman7920

@sandman7920 sandman7920 commented Jun 15, 2021

Copy link
Copy Markdown
Contributor

There is some strange bug on windows with the system styles (windows and windowsvista).
When styleproxy is used and QDockWidget has a custom stylesheet applied to the widget title, close-button and float-button are rendered huge.

See #2485

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sandman7920 added 5 commits June 12, 2021 22:15
@sandman7920
Application: Move DB4SProxyStyle to the Application unit.
a39ea9d 
Set default maximum icon size for QToolBar to 20px, and for MenuItem to 16px,
before that MenuItem icon was bigger than QToolBar icon.

Pixel metric for SmallIconSize is set to 12px to avoid strange
render behaviour for QDockWidget with custom stylesheet.
@sandman7920
TableBrowserDock: Change title style
aada909
@sandman7920
Application: styleproxy now uses screen->logicalDotsPerInch()
c0a7529
@sandman7920
Application: PM_SmallIconSize (QDockWidgets with custom stylesheet) w…
591c566 
…orkaround is applied for windows only.

Screen detection now use QDesktopWidget::screenNumber(const QWidget *widget = nullptr)

toolBarIconSize is set to 18
@sandman7920
Application: Move DB4SProxyStyle before MainWindow is created.
ee6a504 
DB4SProxyStyle is set before any Widget is created.
QGuiApplication::primaryScreen() is used as a screen.
Now custom QPalette can be set before MainWindows is created,
for example exported palette from KDE (Breeze, Breeze Dark, etc).
@mgrojo
mgrojo self-requested a review June 15, 2021 21:48
@sandman7920

sandman7920 commented Jun 16, 2021

Copy link
Copy Markdown
Contributor Author

Screenshot with breeze dark palette imported into DB4s in windows (fusion style).
Looks much more native than a current dark theme.
I will test in macOS to see if it works with macintosh style plugin.

DB4S_dark
justinclift reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mgrojo added a commit that referenced this pull request Jun 18, 2021
@mgrojo
Merge pull request #2741
0f8b3cc 
Workaround for WindowsVista style (qwindowsvistastyle plugin)

There is some strange bug on windows with the system styles (windows
and windowsvista).  When styleproxy is used and QDockWidget has a
custom stylesheet applied to the widget title, close-button and
float-button are rendered huge.

See #2485
@mgrojo
mgrojo merged commit ee6a504 into sqlitebrowser:master Jun 18, 2021
@mgrojo

mgrojo commented Jun 18, 2021

Copy link
Copy Markdown
Member

I like the new style, nice work! It's now merged.
justinclift reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrojo mgrojo Awaiting requested review from mgrojo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sandman7920 @mgrojo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.