GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Returning support by bmalrat · Pull Request #2854 · sqlitebrowser/sqlitebrowser

Conversation

@bmalrat

@bmalrat bmalrat commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

Hello

This will fix #2720
I tested it with the sample https://www.sqlite.org/lang_returning.html

CREATE TABLE t0(
  a INTEGER PRIMARY KEY,
  b DATE DEFAULT CURRENT_TIMESTAMP,
  c INTEGER
);
INSERT INTO t0(c) VALUES(random()) RETURNING *;

and with row:

INSERT INTO t0(c) VALUES(random()),(random()),(random()),(random()),(random()) RETURNING *;

The bug was in the row loader that try to append "LIMIT 49999 OFFSET 0" but it's not a SELECT

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ambaca reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bmalrat bmalrat changed the title Fix Returning support Draft: Fix Returning support Oct 4, 2021
@bmalrat

bmalrat commented Oct 4, 2021

Copy link
Copy Markdown
Contributor Author

I spotted some other bug with DELETE that didn't commit the change and the change buttons are not affected.
I will try to rework it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bmalrat
bmalrat force-pushed the FixReturning branch from bc6bdb5 to 1d486de Compare October 4, 2021 02:59
@bmalrat bmalrat changed the title Draft: Fix Returning support Fix Returning support Oct 4, 2021
@bmalrat

bmalrat commented Oct 4, 2021

Copy link
Copy Markdown
Contributor Author

My rework fixed the
DELETE FROM t0 RETURNING *;
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bmalrat
bmalrat force-pushed the FixReturning branch from bf07016 to 5631b37 Compare November 19, 2021 01:31
@MKleusberg
MKleusberg force-pushed the master branch 5 times, most recently from d396227 to 16035be Compare December 26, 2021 13:41
@bmalrat
bmalrat force-pushed the FixReturning branch from 5631b37 to a18a894 Compare January 11, 2022 20:39
@bmalrat
bmalrat force-pushed the FixReturning branch from a18a894 to 35cb46e Compare May 19, 2022 23:54
bmalrat added 2 commits May 19, 2022 20:02
@bmalrat
Fix Returning support
592fe4f
@bmalrat
update comments
eb6d7d2
@bmalrat
bmalrat force-pushed the FixReturning branch from 35cb46e to eb6d7d2 Compare May 20, 2022 00:03
@justinclift

justinclift commented Oct 26, 2022

Copy link
Copy Markdown
Member

@MKleusberg Should this be merged? 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lucydodo
lucydodo force-pushed the master branch 3 times, most recently from 4bc0c36 to e0a000c Compare July 2, 2023 13:12
mgrojo pushed a commit that referenced this pull request Sep 6, 2023
@bmalrat @mgrojo
Fix Returning support (#2854)
299666d 
See issue #2720.
@mgrojo

mgrojo commented Sep 6, 2023

Copy link
Copy Markdown
Member

I've finally included this in 299666d, but it hasn't been detected by GitHub as a merge of this pull request, because it was cherry-picked, squashed and modified to remove compilation problems due to incompatibility to current code. I'll close this as finished, then. Thanks, @bmalrat.
justinclift and bmalrat reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mgrojo mgrojo closed this Sep 6, 2023
@josephvusich josephvusich mentioned this pull request Feb 1, 2025
[Bug]: Silent failure when executing "WITH ... INSERT ... RETURNING" #3858
Open
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RETURNING keyword not implemented?

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bmalrat @justinclift @mgrojo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.