GeezerVison

Waiting for stackphp/CallableHttpKernel#3 to add missing tests.

Do we need to terminate them based on them being matched? I'm not sure, related to stackphp/builder#14

The goal of UrlMap stack is to manage only one matching app, so I think we should apply the same logic in handle() and terminate(), and ignore all non matching apps.

But it's one matching app per request, the HttpCache middleware could and would fire multiple requests through the app before terminate happens.

Good point ;) I updated the PR accordingly.

I tested the UrlMap on a Silex project, with the WebProfiler provider which use the terminate kernel event. All seems good.

Just thought of a really minor thing, perhaps we should keep track of the apps that have been terminated, something like:

$terminated = [];
foreach ($this->map as $path => $app) {
    if ($app instanceof TerminableInterface && !in_array($app, $terminated, true)) {
        $app->terminate($request, $response);
        $terminated[] = $app;
    }
}

Not sure if that would be overkill. I personally think terminate should be idempotent, so shouldn't matter.

Other than that, let's

Thanks!