Description

caub

opened on Feb 13, 2019

Issue body actions

StackFrame constructor doesn't accept object with null prototype:

> const StackFrame = require('stackframe');
undefined
> new StackFrame({fileName:'lol'})
{ fileName: 'lol' }
> new StackFrame(Object.assign(Object.create(null),{fileName:'lol'}))
{}
> new StackFrame('lol'.match(/(?<fileName>\w+)/).groups)
{}

$ npm ls stackframe
├── [email protected] 
└─┬ [email protected]
  └── [email protected]  deduped

Activity

1. devsnek commented on Feb 13, 2019

   

   devsnek

   on Feb 13, 2019

   More actions

   issue is obj instanceof Object, which is... a weird way to test for objects, to say the least. it also uses obj.hasOwnProperty lower down which will cause issues when the first part is fixed.
2. caub

   added a commit that references this issue on Feb 13, 2019

   fix stacktracejs#18

   This issue will close once commit 688174b is merged into the 'master' branch.

   688174b
3. caub

   added 3 commits that reference this issue on Feb 20, 2019

   fix stacktracejs#18

   This issue will close once commit 8226d7d is merged into the 'master' branch.

   8226d7d

   fix stacktracejs#18

   This issue will close once commit 1c1c21e is merged into the 'master' branch.

   1c1c21e

   fix stacktracejs#18

   This issue will close once commit b506512 is merged into the 'master' branch.

   b506512
4. eriwen

   self-assigned this

   on Sep 14, 2019
5. caub

   added a commit that references this issue on Sep 20, 2019

   fix stacktracejs#18

   This issue will close once commit 147b7a5 is merged into the 'master' branch.

   147b7a5
6. eriwen

   closed this as completedin 147b7a5on Jan 5, 2020

Issue actions