GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add bower dependencies by oliversalzburg · Pull Request #136 · stacktracejs/stacktrace.js

Conversation

oliversalzburg commented Oct 15, 2015

Copy link

Copy Markdown

Contributor

Fixes #134

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

eriwen commented Oct 16, 2015

Copy link

Copy Markdown

Member

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

oliversalzburg commented Oct 16, 2015

Copy link

Copy Markdown

Contributor Author

@eriwen We should probably tag stacktrace-gps and stacktrace.js with a patch update and update the bower.json to that version. Then the dependencies should be pulled in.

Another option I was considering was to specify the .min.js version as the main file. That one contains all the dependencies as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@oliversalzburg Yes, we should tag and publish a new release for those projects. You no longer have to wait for me to publish to npm! Make sure to bump and push gps, then bump the versions in stacktrace.js, tag and push that.

Regarding the bower dependencies, we used .min.js for component.json, so it makes sense to do the same here. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

oliversalzburg commented Oct 18, 2015

Copy link

Copy Markdown

Contributor Author

@eriwen Okay, so, if we set the .min.js versions in the main section, then we don't really need to specify other packages as dependencies. We should set the referenced packages as devDependencies then instead.

Unless you disagree, I would make that change, merge, tag, push and npm publish :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eriwen reviewed

Oct 19, 2015

View reviewed changes

Comment thread

bower.json Outdated

eriwen Oct 19, 2015

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump this to 2.3.0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

eriwen commented Oct 19, 2015

Copy link

Copy Markdown

Member

Once we can rebase this PR on the HEAD of master and update the stacktrace-gps dependency, you can merge this and push a new version @oliversalzburg. Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

oliversalzburg mentioned this pull request

Oct 19, 2015

Add dependencies to bower.json #138

Closed


          Add bower dependencies

77511e3

oliversalzburg added a commit that referenced this pull request

Oct 19, 2015


          Merge pull request #136 from oliversalzburg/fix/bower

Add bower dependencies

oliversalzburg merged commit 2934891 into stacktracejs:master

Oct 19, 2015

oliversalzburg deleted the fix/bower branch

October 19, 2015 18:46

oliversalzburg commented Oct 19, 2015

Copy link

Copy Markdown

Contributor Author

I didn't change the main to the minified build as the component.json actually doesn't reference it either. Not sure how to proceed here. I still think it would make sense to make that change, but I wanted to delay it until a working bower setup is in place.

I pushed a 1.0.1 tag and published to npm. I didn't touch the dependencies as a bower i stacktrace-js seems to already perform as intended. Not sure if anything else is actually needed.

I'll probably reference the bower dependency in our own projects very soon and then I'll get some real-world experience and adjust accordingly, if necessary.

$ bower i stacktrace-js
bower stacktrace-js#*           cached git://github.com/stacktracejs/stacktrace.js.git#1.0.0
bower stacktrace-js#*         validate 1.0.0 against git://github.com/stacktracejs/stacktrace.js.git#*
bower stacktrace-js#*              new version for git://github.com/stacktracejs/stacktrace.js.git#*
bower stacktrace-js#*          resolve git://github.com/stacktracejs/stacktrace.js.git#*
bower stacktrace-js#*         download https://github.com/stacktracejs/stacktrace.js/archive/1.0.1.tar.gz
bower stacktrace-js#*          extract archive.tar.gz
bower stacktrace-js#*         resolved git://github.com/stacktracejs/stacktrace.js.git#1.0.1
bower stacktrace-gps#~2.3.0 not-cached git://github.com/stacktracejs/stacktrace-gps.git#~2.3.0
bower stacktrace-gps#~2.3.0    resolve git://github.com/stacktracejs/stacktrace-gps.git#~2.3.0
bower stack-generator#~1.0.7    cached git://github.com/stacktracejs/stack-generator.git#1.0.7
bower stack-generator#~1.0.7  validate 1.0.7 against git://github.com/stacktracejs/stack-generator.git#~1.0.7
bower error-stack-parser#~1.2.3 cached git://github.com/stacktracejs/error-stack-parser.git#1.2.3
bower error-stack-parser#~1.2.3         validate 1.2.3 against git://github.com/stacktracejs/error-stack-parser.git#~1.2.3
bower stacktrace-gps#~2.3.0             download https://github.com/stacktracejs/stacktrace-gps/archive/2.3.0.tar.gz
bower stackframe#~0                       cached git://github.com/stacktracejs/stackframe.git#0.3.1
bower stackframe#~0                     validate 0.3.1 against git://github.com/stacktracejs/stackframe.git#~0
bower stacktrace-gps#~2.3.0              extract archive.tar.gz
bower stacktrace-gps#~2.3.0             resolved git://github.com/stacktracejs/stacktrace-gps.git#2.3.0
bower source-map#0.5.1                    cached git://github.com/mozilla/source-map.git#0.5.1
bower source-map#0.5.1                  validate 0.5.1 against git://github.com/mozilla/source-map.git#0.5.1
bower stacktrace-js#~1.0.1               install stacktrace-js#1.0.1
bower error-stack-parser#~1.2.3          install error-stack-parser#1.2.3
bower stack-generator#~1.0.7             install stack-generator#1.0.7
bower stackframe#~0                      install stackframe#0.3.1
bower stacktrace-gps#~2.3.0              install stacktrace-gps#2.3.0
bower source-map#0.5.1                   install source-map#0.5.1

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eriwen commented Nov 7, 2015

Copy link

Copy Markdown

Member

@oliversalzburg Yeah, this works just fine. The only possible hangup I can see is the complexity of including all dependencies if a consumer does not use the minified version at bower_components/stacktrace-js/dist/stacktrace.min.js

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eriwen pushed a commit that referenced this pull request

Apr 16, 2016


          Merge pull request #136 from oliversalzburg/fix/bower

d43a038

Add bower dependencies

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.