Description

itsmarco

opened on Dec 5, 2016

Issue body actions

Hello,

I was parsing some packaged workbooks with and I encountered a problem. A .twbx I was trying to open had a bunch of .key files in it, which adhere to some xml structure. The function find_file_in_zip tries to pass this xml file on as a .twb, ultimately raising an tableaudocumentapi.xfile.TableauVersionNotSupportedException: 0.0 error.

The workbook is actually a valid workbook, and ended up not getting parsed. Manually excluding .key files fixed the issue for me.

Cheers,
Marco

Activity

1. t8y8 commented on Dec 5, 2016

   

   t8y8

   on Dec 5, 2016

   Contributor

   More actions

   @itsmarco would it be possible to attach a workbook that reproduces the issue?

   I think I see where the problem is -- we return the first successfully parsed file, because the root_element check happens a layer above. One fix is to only try and parse .twb/.tds files.
2. itsmarco commented on Dec 6, 2016

   

   itsmarco

   on Dec 6, 2016

   Author

   More actions

   @t8y8 unfortunately I cannot. What I can tell you is that the .twbx contains a folder named TwbxExternalCache, which contains two subfolders: TwbxResultsCacheV3 & TwbxTimestampsCacheV3. These folders contains .key & .bin files. A .key file is attached.
   .key.txt
3. t8y8

   self-assigned this

   on Dec 6, 2016
4. t8y8

   added

   bug

   on Dec 10, 2016
5. t8y8

   added a commit that references this issue on Dec 12, 2016

   Fix #117 by only attempting files with the right extension inside the…

   This issue will close once commit fb36a3a is merged into the 'master' branch.

   fb36a3a
6. t8y8 commented on Dec 12, 2016

   

   t8y8

   on Dec 12, 2016

   Contributor

   More actions

   @itsmarco this should be fixed in the development branch and included in the next release.

   Can you give it a quick try to confirm?
7. itsmarco commented on Dec 12, 2016

   

   itsmarco

   on Dec 12, 2016

   Author

   More actions

   @t8y8 Fixed worked. Thanks :)
8. t8y8 commented on Dec 12, 2016

   

   t8y8

   on Dec 12, 2016

   Contributor

   More actions

   Awesome! Thank you for verifying!
9. t8y8

   closed this as completedon Dec 12, 2016
10. graysonarts

    added a commit that references this issue on Jan 11, 2017

    Release 0.6 (#126)

    This issue will close once commit 65fbc80 is merged into the 'master' branch.

    65fbc80

Issue actions