GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Scrub some strings in the test files by t8y8 · Pull Request #82 · tableau/document-api-python

Conversation

@t8y8

@t8y8 t8y8 commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

Removing the 'tsi.lan' suffix that's internal to Tableau and not really relevant for general usage

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
t8y8 added 2 commits September 9, 2016 10:35
@t8y8
Scrub some strings in the test file so they don't include internal re…
2b46870 
…ferences
@t8y8
Scrub some strings in the test file so they don't include internal re…
b229dbf 
…ferences for reals
@t8y8
t8y8 changed the base branch from master to development September 9, 2016 17:50
@t8y8 t8y8 mentioned this pull request Sep 11, 2016
Clean up connection strings in assets #79
Closed
@t8y8

t8y8 commented Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

Ping (I'm just OCD and want to clear my open PRs)

/cc @RussTheAerialist
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graysonarts

graysonarts commented Sep 13, 2016

Copy link
Copy Markdown
Contributor

I'm oof today because my dog is having a surgery. I'll take a look tomorrow
On Tue, Sep 13, 2016 at 13:42 Tyler Doyle [email protected] wrote:

Ping (I'm just OCD and want to clear my open PRs)

/cc @RussTheAerialist https://github.com/RussTheAerialist

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#82 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFxVdaevg5VdVzAJIdBsA7SX5UqyP3fks5qpwrLgaJpZM4J5SI0
.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LGraber
LGraber reviewed Sep 13, 2016
View reviewed changes
Comment thread test/bvt.py
self.assertIsInstance(connections, list)
self.assertIsInstance(connections[0], Connection)
self.assertEqual(connections[0].dbname, 'testv1')
self.assertEqual(connections[0].dbname, 'TestV1')

@LGraber LGraber Sep 13, 2016

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this pass before?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@t8y8 t8y8 Sep 13, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test asset had it lowercase too, my OCD said 'no' and I updated it to match the others

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@LGraber LGraber Sep 13, 2016

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is OOOCCCDDD

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@LGraber

LGraber commented Sep 13, 2016

Copy link
Copy Markdown

🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@t8y8
t8y8 merged commit 5f91af0 into tableau:development Sep 13, 2016
@t8y8
t8y8 deleted the 79-bugfix-cleanup-test-strings branch September 13, 2016 21:00
graysonarts pushed a commit that referenced this pull request Oct 7, 2016
@t8y8 Russell Hay
Scrub some strings in the test files (#82)
9974238 
* Scrub some strings in the test file so they don't include internal references
* Updated some of the assets to be consistent in casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@t8y8 @graysonarts @LGraber
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.