GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #86 Repository location stripping by graysonarts · Pull Request #88 · tableau/document-api-python

Conversation

@graysonarts

@graysonarts graysonarts commented Sep 29, 2016

Copy link
Copy Markdown
Contributor

Addresses #86

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Russell Hay added 3 commits September 29, 2016 15:31
Russell Hay
Fixing xfile's save_as functionality for non .t*x files
f8bf9c9
Russell Hay
Add the ability to clear repository location on the datasource for re…
c1cd59b 
…targetting
Russell Hay
fixing a pep8 issue that was missed
bd3dda6
t8y8
t8y8 approved these changes Sep 29, 2016
View reviewed changes

@t8y8 t8y8 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tableaudocumentapi/xfile.py

if container_file is None:
container_file = new_filename
if new_filename is None:

@t8y8 t8y8 Sep 29, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
t8y8
t8y8 reviewed Sep 29, 2016
View reviewed changes
Comment thread tableaudocumentapi/datasource.py
return self._connections

def clear_repository_location(self):
tag = self._datasourceXML.find('./repository-location')

@t8y8 t8y8 Sep 29, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional that it's ./ here but .// in the test?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
t8y8
t8y8 suggested changes Oct 1, 2016
View reviewed changes

@t8y8 t8y8 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing after taking a second look

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread tableaudocumentapi/datasource.py Outdated

def clear_repository_location(self):
tag = self._datasourceXML.find('./repository-location')
self._datasourceXML.remove(tag)

@t8y8 t8y8 Oct 1, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail and throw a TypeError if the find returns None -- eg if you call this method twice or it never had a repository-location tag.

Do we just want this to return silently instead of blowing up?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@graysonarts graysonarts Oct 1, 2016

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang that was supposed to have an if tag: on it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
t8y8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Russell Hay
Adding None check for repository-location in case it doesn't exist
49713a8
t8y8
t8y8 approved these changes Oct 4, 2016
View reviewed changes
@t8y8

t8y8 commented Oct 4, 2016

Copy link
Copy Markdown
Contributor

🚀 🌕 ⏯️ 🌠
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graysonarts
graysonarts merged commit 2afd4c2 into tableau:development Oct 4, 2016
@graysonarts
graysonarts deleted the repository-location-stripping branch October 4, 2016 18:16
graysonarts pushed a commit that referenced this pull request Oct 7, 2016
Russell Hay Russell Hay
#86 Repository location stripping (#88)
059fe86 
* Add the ability to clear repository location on the datasource for retargetting
* fixing a pep8 issue that was missed
* Adding None check for repository-location in case it doesn't exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@t8y8 t8y8 t8y8 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@graysonarts @t8y8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.