GeezerVison is showing github.com — Fix #87 by working around non-federated sqlproxy connections by t8y8 · Pull Request #89 · tableau/document-api-python
Conversation
t8y8
commented
Sep 30, 2016
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes #87
'sqlproxy' connections can't be federated yet so they exist outside the 'named-connections' groupings that all other connections live in.
The simplest change is to just grab all federated connections and then make a second pass to get the published datasource connections too.
Added a test to verify the case with a mixed-case workbook: Federated and Non-Federated connections
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
graysonarts
pushed a commit
that referenced
this pull request
Oct 7, 2016
When Cross Database Joins were introduced in 10 all connections became "federated" by default, even if they weren't actually joined to anything else.
In the file format that means they get represented as named-connection/connection elements. Expressed under one top-level connection element with a class of 'federated'.
Except for 'sqlproxy' connections (Published Data Sources) -- they stay in the old connection style as a top level connection element.
We need to, when in a 10.0 or greater workbook, get all federated connections (named-connection) plus go back and find any sqlproxy connections as well.
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
