GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix cmake downstream find_package failure in double mode in windows by jasjuang · Pull Request #240 · tinyobjloader/tinyobjloader

Conversation

@jasjuang

@jasjuang jasjuang commented Nov 10, 2019

Copy link
Copy Markdown
Contributor

I realized I only fixed the problem of #229 for Linux while I was trying to update tinyobjloader for vcpkg. This fix allows double mode to work correctly in windows as well. I've tested it on vcpkg and it installs successfully with this change, and a minimal downstream example also works correctly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasjuang
fix cmake downstream find_package failure in double mode in windows
b6bb6f7
@syoyo
syoyo merged commit ba75951 into tinyobjloader:master Nov 10, 2019
@syoyo

syoyo commented Nov 10, 2019

Copy link
Copy Markdown
Collaborator

Awesome! Merged!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasjuang

jasjuang commented Nov 10, 2019

Copy link
Copy Markdown
Contributor Author

@syoyo can we get another release? or retag the 2.0.0-rc2 to the current master, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@syoyo

syoyo commented Nov 10, 2019

Copy link
Copy Markdown
Collaborator

@jasjuang Okay, v2.0.0-rc2 has been retagged.
jasjuang reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
syoyo added a commit that referenced this pull request Nov 10, 2025
@syoyo
Merge pull request #240 from jasjuang/master
4bb59f3 
fix cmake downstream find_package failure in double mode in windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jasjuang @syoyo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.