GeezerVison

Codecov Report

❌ Patch coverage is 64.55696% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.01%. Comparing base (e23569d) to head (96ede9b).
⚠️ Report is 7 commits behind head on master.

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
- Coverage   81.08%   81.01%   -0.08%     
==========================================
  Files          28       28              
  Lines        2506     2623     +117     
  Branches      463      492      +29     
==========================================
+ Hits         2032     2125      +93     
- Misses        352      367      +15     
- Partials      122      131       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Code review

Found 1 issue:

1. Documentation preset table shows wrong format strings for all 5 presets. Each preset in the table omits workspace: from the prefix — e.g., docs show Loading {session} {bar} {progress} {window} but the actual code defines "Loading workspace: {session} {bar} {progress} {window}". This mismatch applies to all five presets (default, minimal, window, pane, verbose).

vs.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

Code review

Found 1 issue:

1. logger.error("workspace build failed", exc_info=True) reverts the deliberate fix in commit ed00d63d ("fix(logging[load]): downgrade logger.exception to debug with exc_info"). That commit intentionally downgraded this to logger.debug because logger.exception() / logger.error(..., exc_info=True) dumps a full Python traceback at ERROR level (visible at default WARNING threshold) alongside the user-friendly tmuxp_echo error message on the next line, causing double output. The tmuxp_echo already handles user-facing error display; the logger.error with exc_info=True re-introduces the duplicate traceback. CLAUDE.md logging standards also say: "Avoid catch-log-reraise without adding new context" and "Exception logging: Avoid logger.exception() followed by raise -- this duplicates the traceback." Here the code catches, logs at ERROR with traceback, and does not re-raise -- it shows a recovery prompt. Should remain logger.debug.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

Code review

Found 1 issue:

1. CHANGES entry references wrong PR number (#1017) instead of (#1020) for the animated progress spinner feature. The #1017 references elsewhere in the file all relate to the structured logging / colorama removal PR, not the spinner.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

Code review

Found 1 issue:

1. logger.debug("workspace build failed") should be logger.error — a workspace build failure stops the operation and prompts the user for recovery (kill/attach/detach). CLAUDE.md log levels say "ERROR: Failures that stop an operation." This same pattern was already corrected from DEBUG to ERROR in builder.py line 515 within this PR, but the analogous handler in load.py was not updated.

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

Code review update: retracting previous finding

The issue I flagged (logger.debug at load.py:409) is a false positive. Upon reviewing git history:

• Commit ed00d63d deliberately downgraded this from logger.exception to logger.debug because logger.exception() dumps tracebacks at ERROR level alongside the user-friendly tmuxp_echo() message, causing double output.
• This differs from the builder.py case: in builder.py, the exception is caught-logged-reraised (adding context justifies ERROR). In load.py, the exception is handled — the user gets a recovery prompt via tmuxp_echo, so DEBUG-level traceback (for --log-level debug diagnostics) is the correct choice.

No issues found. Checked for bugs, git history context, and CLAUDE.md compliance.

🤖 Generated with Claude Code