GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Freeze config for attached session by will-ockmore · Pull Request #660 · tmux-python/tmuxp

Conversation

@will-ockmore

@will-ockmore will-ockmore commented Jan 12, 2021

Copy link
Copy Markdown
Contributor

This PR changes the behaviour of tmuxp freeze to default to the currently attached session. It achieves this by modifying the get_session utility function, will has the side effect of also modifying the behaviour of tmuxp shell to match - as this is the behaviour specified in the docs I believe it's probably fine and was just a bug.

Closes #659

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@will-ockmore
will-ockmore requested a review from tony January 12, 2021 21:18
@will-ockmore will-ockmore self-assigned this Jan 12, 2021
@codecov

codecov Bot commented Jan 12, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #660 (6c5ffe0) into master (97b7e8d) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   75.97%   75.91%   -0.07%     
==========================================
  Files           7        7              
  Lines        1174     1179       +5     
  Branches      304      306       +2     
==========================================
+ Hits          892      895       +3     
- Misses        200      201       +1     
- Partials       82       83       +1
Impacted Files Coverage Δ
tmuxp/workspacebuilder.py 85.26% <ø> (ø)
tmuxp/util.py 84.41% <71.42%> (-1.70%) ⬇️
tmuxp/cli.py 73.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b7e8d...6c5ffe0. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CLAassistant

CLAassistant commented Jan 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tony

tony commented Jan 29, 2022

Copy link
Copy Markdown
Member

@will-ockmore

Sorry for the delay. That is my fault.

Can you give this a rebase?

The docs have since been moved to markdown here: https://github.com/tmux-python/tmuxp/blob/master/docs/cli.md
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
will-ockmore added 4 commits January 29, 2022 13:46
@will-ockmore
fix cli freeze test and remove duplicate cases
199c32e
@will-ockmore
get_session should return attached local session by default
bfc0e07
@will-ockmore
add additional documentation on the freeze command
aa48143
@will-ockmore
fix test naming
4785730
@will-ockmore
will-ockmore force-pushed the freeze_config_for_attached_session branch from aeac96e to 4785730 Compare January 29, 2022 13:56
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6c5ffe0 
for more information, see https://pre-commit.ci
@will-ockmore

will-ockmore commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

@tony no problem. I've moved the changes over to the new markdown docs, I've also signed the CLA 👍
tony reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tony

tony commented Jan 29, 2022

Copy link
Copy Markdown
Member

@will-ockmore Taking a look now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tony
tony merged commit 5bfd582 into tmux-python:master Jan 29, 2022
tony added a commit that referenced this pull request Jan 29, 2022
@tony
docs(CHANGES): Note improvement for tmuxp freeze from #660
e67a72b
@tony

tony commented Jan 29, 2022

Copy link
Copy Markdown
Member

@will-ockmore Merged!

This will ship in the next release
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tony tony mentioned this pull request May 10, 2026
py(deps) Bump libtmux 0.56.0 #1038
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tony tony Awaiting requested review from tony

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@will-ockmore will-ockmore

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tmuxp freeze outputs configuration for first session, not currently attached session

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@will-ockmore @CLAassistant @tony
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.