@nvasilas Can you take a look at the tests?

It looks like this may need a version conditional from libtmux.common, example:

• tmuxp/tmuxp/cli/load.py

  Line 165 in ad6d30b

  if has_gte_version("2.6"):

• tmuxp/tests/test_workspacebuilder.py

  Line 255 in 9a627f6

  sconfig["windows"][0]["options"]["pane-border-format"] = " #P "

Docs on related functions: https://libtmux.git-pull.com/reference/common.html?highlight=has_gt_version#libtmux.common.has_gt_version

@tony Sure mate I 'll fix them.

@nvasilas I rebased your branch via GitHub's rebase button (git pull --rebase --autostash to pull the changes)

The changes include basic mypy support #786

Codecov Report

Merging #793 (28c4366) into master (b70cd70) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files          18       18           
  Lines        1431     1431           
  Branches      337      336    -1     
=======================================
  Hits         1076     1076           
  Misses        267      267           
  Partials       88       88           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvasilas It really works. Nice.

Tested by doing pip install -e ~/path/to/your/tmuxp/branch and doing tmuxp load ./workspacefile.yaml -L another-tmux-server.

Master: b70cd70: Layout is scrunched
This PR: Maintains the layout!

@nvasilas Thank you for this!

Live in v1.13.1

PyPI, GitHub Tag

Any better?

I will reach out to users in the other issues as well

@nvasilas I am deliberating fully reversing the change while we understand the problem better. You can recreate the same PR again, but it's my fault since my tests didn't catch the issues - so I feel bad

The reason why I may reverse it (v1.13.2 and v1.13.3) is it had more of an effect on users with certain kinds of sessions than we both thought it would (#800)

If you have more ideas on this - I am all ears - a bulk of my effort is improving libtmux so issues like this are easier to diagnose. The experience is going to get better, and we'll improve at catching these issues, I promise.

In #809 I added a test for us to check for tmux spacing issues

@nvasilas I've started a new issue at #815 the opportunity arises you'd like to collab (sorry about retracting on this PR, it is my 100% my mess up)

@tony Sorry mate I was abroad and I wasn't able to follow the recent changes. I introduced the bug with my PR and reverting it was the best choice. So, no worries. When I get some free time I will try to find a proper fix.

@nvasilas I will keep you apprised either way 👍 (and vice-versa, hopefully!)