GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(run-ops): dedicated run-ops database package + docker service + migration runner by d-cs · Pull Request #4113 · triggerdotdev/trigger.dev

Conversation

d-cs commented Jul 2, 2026

Copy link

Copy Markdown

Collaborator

What

The dedicated run-ops database foundation for the split: a standalone Prisma package plus the infra to run and migrate it.

internal-packages/run-ops-database — a new Prisma package (@internal/run-ops-database) whose schema mirrors the run-execution tables that will live on the dedicated DB, with its own generated client, migrations, and migration runner.
prisma/schema.parity.test.ts — a parity test that guards the run-ops schema against drift from the control-plane schema for the mirrored tables.
Docker — a Postgres 17 service (docker/Dockerfile.postgres17, docker/docker-compose.yml) so the dedicated DB is available locally under the run-ops compose profile.
Testcontainers — hetero fixtures (PG14 legacy + PG17 dedicated) so later PRs can exercise cross-database behaviour with real containers rather than mocks.

Why

This is the second PR in the run-ops split stack, stacked on the core primitives. It stands up the dedicated database and its tooling. There is no runtime wiring into the webapp here — the app does not read or write this DB yet; that arrives in later PRs. On its own this PR only adds a package, a docker service, and test fixtures.

Tests

Schema-parity test for the run-ops schema; hetero testcontainer fixture smoke test.

Notes

Draft, stacked on feat(core): id-shape residency classifier + ksuid mint primitives (run-ops split base) #4112 (runops/pr01-core-residency). Review that one first; this diff is against it.
Server-change / changeset note to be added at stack-assembly time.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

changeset-bot Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

⚠️ No Changeset found

Latest commit: 00cfae3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1f3d416a-66b6-4525-af0d-cdf3291bd18e

📥 Commits

Reviewing files that changed from the base of the PR and between ea51491 and 00cfae3.

📒 Files selected for processing (1)

.env.example

📜 Recent review details

⏰ Context from checks skipped due to timeout. (33)

GitHub Check: internal / 🧪 Unit Tests: Internal (11, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (5, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (12, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (5, 10)
GitHub Check: internal / 🧪 Unit Tests: Internal (3, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (1, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (7, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (9, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (10, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (6, 10)
GitHub Check: internal / 🧪 Unit Tests: Internal (4, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (6, 12)
GitHub Check: internal / 🧪 Unit Tests: Internal (8, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (8, 10)
GitHub Check: internal / 🧪 Unit Tests: Internal (2, 12)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (7, 10)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (2, 10)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (3, 10)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (4, 10)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (9, 10)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (10, 10)
GitHub Check: webapp / 🧪 Unit Tests: Webapp (1, 10)
GitHub Check: sdk-compat / Node.js 24.18 (blacksmith-4vcpu-ubuntu-2404)
GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-ubuntu-2404 - pnpm)
GitHub Check: sdk-compat / Node.js 26.4 (blacksmith-4vcpu-ubuntu-2404)
GitHub Check: typecheck / typecheck
GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-windows-2025 - npm)
GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-windows-2025 - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (blacksmith-4vcpu-ubuntu-2404 - npm)
GitHub Check: packages / 🧪 Unit Tests: Packages (3, 3)
GitHub Check: packages / 🧪 Unit Tests: Packages (1, 3)
GitHub Check: packages / 🧪 Unit Tests: Packages (2, 3)
GitHub Check: e2e-webapp / 🧪 E2E Tests: Webapp

⚠️ CI failures not shown inline (4)

GitHub Actions: 📝 CLAUDE.md Audit / audit: feat(run-ops): dedicated run-ops database package + docker service + migration runner

Conclusion: failure

View job details

##[group]Run anthropics/claude-code-action@428971d2ecd6e3a7cb0ee0da2a3a8b33fdb3678d
 with:
   anthropic_***REDACTED***
   use_sticky_comment: true
   allowed_bots: devin-ai-integration[bot]
   claude_args: --max-turns 25
--model claude-opus-4-8
--allowedTools "Read,Glob,Grep,Bash(git diff:*)"
   prompt: You are reviewing a PR to check whether any CLAUDE.md files or .claude/rules/ files need updating.
## Your task
1. Run `git diff origin/main...HEAD --name-only` to see which files changed in this PR.
2. For each changed directory, check if there's a CLAUDE.md in that directory or a parent directory.
3. Determine if any CLAUDE.md or .claude/rules/ file should be updated based on the changes. Consider:
   - New files/directories that aren't covered by existing documentation
   - Changed architecture or patterns that contradict current CLAUDE.md guidance
   - New dependencies, services, or infrastructure that Claude should know about
   - Renamed or moved files that are referenced in CLAUDE.md
   - Changes to build commands, test patterns, or development workflows
## Response format
If NO updates are needed, respond with exactly:
✅ CLAUDE.md files look current for this PR.
If updates ARE needed, respond with a short list:
📝 **CLAUDE.md updates suggested:**
- `path/to/CLAUDE.md`: [what should be added/changed]
- `.claude/rules/file.md`: [what should be added/changed]
Keep suggestions specific and brief. Only flag things that would actually mislead Claude in future sessions.
Do NOT suggest updates for trivial changes (bug fixes, small refactors within existing patterns).
Do NOT suggest creating new CLAUDE.md files - only updates to existing ones.
   trigger_phrase: `@claude`
   label_trigger: claude
   branch_prefix: claude/
   use_bedrock: false
   use_vertex: false
   use_foundry: false
   classify_inline_comments: true
   use_commit_signing: false
   bot_id: 41898282
   bot_name: claude[bot]
   track_progress: false
   include_fix_links: true
   display_report: false...

GitHub Actions: 📝 CLAUDE.md Audit / 0_audit.txt: feat(run-ops): dedicated run-ops database package + docker service + migration runner

Conclusion: failure

View job details

igger.dev/[email protected] -> `@trigger.dev/yalt`@3.0.0-beta.46
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.47 -> `@trigger.dev/yalt`@3.0.0-beta.47
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.48 -> `@trigger.dev/yalt`@3.0.0-beta.48
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.49 -> `@trigger.dev/yalt`@3.0.0-beta.49
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.5 -> `@trigger.dev/yalt`@3.0.0-beta.5
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.50 -> `@trigger.dev/yalt`@3.0.0-beta.50
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.51 -> `@trigger.dev/yalt`@3.0.0-beta.51
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.52 -> `@trigger.dev/yalt`@3.0.0-beta.52
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.53 -> `@trigger.dev/yalt`@3.0.0-beta.53
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.55 -> `@trigger.dev/yalt`@3.0.0-beta.55
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.6 -> `@trigger.dev/yalt`@3.0.0-beta.6
  * [new tag]             `@trigger.dev/yalt`@3.0.0-beta.7 -> `@trigger.dev/yalt`@3.0.0-beta.7
  * [new tag]             build-alert-hotfix.rc1      -> build-alert-hotfix.rc1
  * [new tag]             build-alert-hotfix.rc2      -> build-alert-hotfix.rc2
  * [new tag]             build-arm-builds-rc.1       -> build-arm-builds-rc.1
  * [new tag]             build-arm-builds-rc.2       -> build-arm-builds-rc.2
  * [new tag]             build-arm-builds-rc.3       -> build-arm-builds-rc.3
  * [new tag]             build-batchid-carryover-rc.0 -> build-batchid-carryover-rc.0
  * [new tag]             build-batching-rc.1         -> build-batching-rc.1
  * [new tag]             build-batching-rc.2         -> build-batching-rc.2
  * [new tag]             build-billing-0.0.1         -> build-billing-0.0.1
  * [new tag]             build-billing-0.0.2         -> build-billing-0.0.2
  * [new tag]             build-billing-0.0.3         -> build-billing-0.0.3
  * [new tag]             build-buildinfo-rc.0 ...

GitHub Actions: 🔎 REVIEW.md Drift Audit / 0_audit.txt: feat(run-ops): dedicated run-ops database package + docker service + migration runner

Conclusion: failure

View job details

-> build-legacy-run-engine.fix2
  * [new tag]             build-legacy-run-engine.fix3 -> build-legacy-run-engine.fix3
  * [new tag]             build-manual-checkpoints.rc1 -> build-manual-checkpoints.rc1
  * [new tag]             build-metadata-upgrade-logging.rc1 -> build-metadata-upgrade-logging.rc1
  * [new tag]             build-metadata-upgrade-logging.rc2 -> build-metadata-upgrade-logging.rc2
  * [new tag]             build-metadata-upgrade-logging.rc3 -> build-metadata-upgrade-logging.rc3
  * [new tag]             build-new-build-system.rc.1 -> build-new-build-system.rc.1
  * [new tag]             build-otel-upgrade-rc.0     -> build-otel-upgrade-rc.0
  * [new tag]             build-otel-upgrade-rc.1     -> build-otel-upgrade-rc.1
  * [new tag]             build-pre-pull-deployments-rc.1 -> build-pre-pull-deployments-rc.1
  * [new tag]             build-prod-rescue-rc.1      -> build-prod-rescue-rc.1
  * [new tag]             build-rate-limiter-fix-rc.1 -> build-rate-limiter-fix-rc.1
  * [new tag]             build-re2.rc0               -> build-re2.rc0
  * [new tag]             build-realtime-v2-stream-fix -> build-realtime-v2-stream-fix
  * [new tag]             build-realtime-v2-stream-fix-2 -> build-realtime-v2-stream-fix-2
  * [new tag]             build-realtime-v2-stream-fix-3 -> build-realtime-v2-stream-fix-3
  * [new tag]             build-realtime-v2-stream-fix-4 -> build-realtime-v2-stream-fix-4
  * [new tag]             build-realtime-v2-stream-fix-5 -> build-realtime-v2-stream-fix-5
  * [new tag]             build-realtimestreams-dedupe -> build-realtimestreams-dedupe
  * [new tag]             build-registry-maintenance-rc.1 -> build-registry-maintenance-rc.1
  * [new tag]             build-registry-maintenance-rc.2 -> build-registry-maintenance-rc.2
  * [new tag]             build-remote-ecr-rc.0       -> build-remote-ecr-rc.0
  * [new tag]             build-reschedule-hotfix.rc1 -> build-reschedule-hotfix.rc1
  * [new tag]             buil...

GitHub Actions: 🔎 REVIEW.md Drift Audit / audit: feat(run-ops): dedicated run-ops database package + docker service + migration runner

Conclusion: failure

View job details

##[group]Run anthropics/claude-code-action@428971d2ecd6e3a7cb0ee0da2a3a8b33fdb3678d
 with:
   anthropic_***REDACTED***
   use_sticky_comment: true
   allowed_bots: devin-ai-integration[bot]
   claude_args: --max-turns 30
--allowedTools "Read,Glob,Grep,Bash(git diff:*)"
   prompt: You are auditing this PR for drift against `.claude/REVIEW.md`.
## Context
`.claude/REVIEW.md` is the repo's source of truth for what AI / agent code reviewers should treat as critical findings (rolling-deploy safety, hot-table indexes, recovery-path queries, testcontainers usage, Lua versioning, etc.). It is consumed by review agents to calibrate severity. If REVIEW.md goes stale, every future agent review degrades.
## Strategy — read this first
You have a hard turn budget. Spend it on signal, not coverage. The audit is allowed to miss things; it is NOT allowed to time out.
1. Read `.claude/REVIEW.md` once, in full.
2. Run `git diff origin/main...HEAD --name-only` to get the list of changed files. Do NOT read the diff content yet.
3. Scan the file-list for relevance to REVIEW.md scope. Relevance signals: changes to Prisma schema, Redis / queue / Lua code, hot tables, recovery / restart loops, new packages, deletions of paths REVIEW.md cites. Skim everything else.
4. Open at most **5 files** total — only the ones most likely to surface a real signal. If nothing in the file-list looks relevant to any REVIEW.md rule, do NOT read any files; go straight to the verdict.
5. Form a verdict and stop. Do not exhaust the turn budget exploring.
Large PRs (>50 files changed) are a strong signal to be MORE selective, not more thorough. Pick 3-5 files at most.
## What to look for
- **Stale references** — does any REVIEW.md rule cite a file, directory, function, table, Prisma model, or package name that has been removed or renamed in this PR (or is already gone from `main`)?
- **Contradictions** — does code in this PR clearly violate a current REVIEW.md rule? (Don't re-review the PR. Only flag if REVIE...

🧰 Additional context used

🧠 Learnings (5)

📚 Learning: 2026-04-13T21:43:58.707Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3368
File: apps/webapp/app/services/taskIdentifierRegistry.server.ts:49-58
Timestamp: 2026-04-13T21:43:58.707Z
Learning: In `apps/webapp/app/services/taskIdentifierRegistry.server.ts` (and closely related task registry/sync code in this module), an empty deployment (zero tasks) is not a realistic/expected scenario. Do not flag or require special handling or fallback logic for missing empty-task cases in this registry/sync flow.

Applied to files:

.env.example

📚 Learning: 2026-04-23T13:26:27.529Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3430
File: apps/webapp/app/presenters/v3/RunStreamPresenter.server.ts:0-0
Timestamp: 2026-04-23T13:26:27.529Z
Learning: In this codebase’s SSE implementation (notably `apps/webapp/app/utils/sse.ts` and its SSE callers such as `apps/webapp/app/presenters/v3/RunStreamPresenter.server.ts`), do not treat `.abort()` vs `.abort("<reason string>")` differences as a heap retention/memory leak issue on Node 20. Heap deltas are identical once `AbortSignal.any` is not involved; the investigated SSE memory leak root cause was `AbortSignal.any` (via FinalizationRegistry behavior on abort). When reviewing, focus on whether `AbortSignal.any` (or similar signal-combining/finalization patterns) is used in the SSE abort path rather than the presence/contents of the abort reason string. Named abort-reason sentinel constants (e.g., `ABORT_REASON_*`) are for readability/style only, not correctness.

Applied to files:

.env.example

📚 Learning: 2026-04-30T21:28:35.705Z

Learnt from: samejr
Repo: triggerdotdev/trigger.dev PR: 3473
File: internal-packages/database/prisma/schema.prisma:59-60
Timestamp: 2026-04-30T21:28:35.705Z
Learning: In this repo, session-duration lower-bound validation is intentionally enforced only at the app layer (via `isAllowedSessionDuration` and `SESSION_DURATION_OPTIONS`), where the minimum allowed value is 300 seconds (5 minutes). `User.sessionDuration` is `Int` (non-nullable) and `Organization.maxSessionDuration` is `Int?` (nullable). There are currently no DB-level `CHECK` constraints for these fields anywhere in the migrations, so future reviews should not flag the absence of DB `CHECK` constraints on these session-duration fields—focus validation on the app-layer logic instead.

Applied to files:

.env.example

📚 Learning: 2026-05-12T06:43:09.116Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3558
File: internal-packages/run-engine/src/run-queue/index.ts:420-424
Timestamp: 2026-05-12T06:43:09.116Z
Learning: In internal-packages/run-engine/src/run-queue/index.ts, the RunQueue “read-path” counter/concurrency methods (e.g., lengthOfQueue/lengthOfQueues/currentConcurrencyOfQueues) intentionally “fail open” on transient Redis pipeline result errors. If you see pipeline result errors (e.g., baseErr/ctrErr) being coerced to 0 (treating Redis command errors the same as missing keys) rather than surfaced/thrown, do not flag it as a bug and do not suggest propagating those errors in future reviews.

Applied to files:

.env.example

📚 Learning: 2026-05-19T21:04:49.990Z

Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3671
File: packages/trigger-sdk/src/v3/ai.ts:724-769
Timestamp: 2026-05-19T21:04:49.990Z
Learning: In packages/trigger-sdk/src/v3/ai.ts, when reviewing recovery/replay of turns, do NOT flag “lost metadata on recovered turns” if the recovered turns are reconstructed via the recovery boot queue that maps metadata by message.id (using replaySessionInTail’s {message, metadata, seqNum} per session.in record). If a message has no matching session.in record (e.g., hook-synthesized messages), the code intentionally falls back to the current boot payload’s metadata—this fallback is expected behavior.

Applied to files:

.env.example

🔇 Additional comments (1)

.env.example (1)

10-13: LGTM!

Walkthrough

This PR introduces a dedicated run-ops PostgreSQL 17 database alongside the existing PG14 control-plane database. It adds a new @internal/run-ops-database package with its own Prisma schema, migrations, and generated client alias, plus Docker and compose support for a separate PG17 service. Testcontainers are extended with schema-push helpers and heterogeneous PG14/PG17 fixtures, and a parity test verifies the run-ops schema’s relation layout.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	It omits required template sections like Closes #, checklist, changelog, and screenshots, and doesn't follow the repository template.	Add the missing template sections: Closes #, checklist items, Testing steps, Changelog, and Screenshots, then fill them in.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is specific and matches the main change: a dedicated run-ops database package with Docker support and migration tooling.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch runops/pr02-db-foundation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

d-cs self-assigned this

Jul 2, 2026

pkg-pr-new Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@ea51491

trigger.dev

npm i https://pkg.pr.new/trigger.dev@ea51491

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@ea51491

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@ea51491

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@ea51491

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@ea51491

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@ea51491

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@ea51491

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@ea51491

commit: ea51491

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

devin-ai-integration Bot reviewed

Jul 2, 2026

View reviewed changes

devin-ai-integration Bot left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

d-cs mentioned this pull request

Jul 2, 2026

feat(run-ops): cross-producer ClickHouse version helper + cross-Postgres-version compat tests #4114

Merged

This comment was marked as resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

d-cs force-pushed the runops/pr02-db-foundation branch from 32525bb to 9b2b67d Compare

July 2, 2026 18:02

d-cs commented Jul 2, 2026

Copy link

Copy Markdown

Collaborator Author

Thanks for the review. On the three nitpicks:

Extract shared PG17 bootstrap helper (testcontainers/src/index.ts): applied in d1fd926. The two singletons now share a bootstrapPg17TemplateContainer(pushSchema) helper so the image, command flags, initdb args, and template-DB creation can't drift.
Move prisma CLI to devDependencies (run-ops-database/package.json): keeping as-is. This intentionally mirrors the sibling @internal/database package, which also lists prisma under dependencies. It's a private, unpublished internal package, so there is no production-install bloat, and matching the sibling keeps the two Prisma packages consistent.
Derive the partial-index DDL from the migration file (testcontainers/src/utils.ts): keeping as-is. The two CREATE UNIQUE INDEX statements differ only by IF NOT EXISTS (the helper is idempotent for template reuse) and are documented as mirrors. Scraping the SQL text out of the migration at test time would add its own parsing fragility for a single stable index literal; the marginal drift risk doesn't justify it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

d-cs force-pushed the runops/pr02-db-foundation branch 2 times, most recently from dc3d806 to 026833a Compare

July 3, 2026 08:51

d-cs force-pushed the runops/pr01-core-residency branch from bde3714 to a98ebac Compare

July 3, 2026 09:12

d-cs force-pushed the runops/pr02-db-foundation branch 2 times, most recently from 23edf6d to 739c923 Compare

July 3, 2026 09:57

Base automatically changed from runops/pr01-core-residency to main

July 3, 2026 10:05

d-cs and others added 7 commits

July 3, 2026 11:12


          feat(run-ops): dedicated run-ops database package + docker service + …

a306598

…migration runner

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>


          restore Electric testcontainer fixtures removed in the run-ops db fou…

a6a955a

…ndation

The db-foundation change dropped createElectricContainer, the electricOrigin
fixture, the ContainerWithElectric* context types, and the
containerWithElectricTest / containerWithElectricAndRedisTest fixtures. That
Electric infra is unrelated to the run-ops db split, is being sunset on its own
track, and is still consumed by apps/webapp/test/realtimeClient.test.ts (which
imports containerWithElectricAndRedisTest) — so its removal here also broke that
import. Restore it verbatim; the new PG17 run-ops fixtures are unaffected.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>


          remove redundant migrate-run-ops.mjs script

1c239fa

The run-ops database is migrated first-class by the @internal/run-ops-database
package's own prisma migrate deploy (its schema.prisma datasource reads
RUN_OPS_DATABASE_URL and it owns its own migrations dir), which the root
db:migrate already sweeps via turbo. The bespoke script instead ran prisma
migrate deploy from the control-plane database package against the run-ops DB,
applying the full control-plane migration history rather than the run-ops subset
— redundant with the native flow and wrong. Drop the script and its two script
entries (root package.json, database package.json).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>


          docs(run-ops db): document per-table divergence from the control-plan…

1a5665c

…e schema

Rework the run-ops schema comments so they read as documentation rather than
working notes. Replaces the top-of-file header with prose describing the
subset relationship and the three relation-handling rules, adds a short header
above each model stating how it differs from its control-plane counterpart
(which relations are scalar-only FKs, which are FK-free join models, which stay
as real FKs), and removes the stale group-(A)/group-(B)/"drop" tags. Comments
only; no model, field, type, attribute, index, or enum is changed.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>


          style(run-ops): apply oxfmt

5b0ef33

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>


          test(run-ops): strip schema comments before parity regexes; dedupe PG…

3459b33

…17 fixture bootstrap

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>


          build(run-ops): regenerate pnpm-lock after rebase onto main

ea51491

d-cs force-pushed the runops/pr02-db-foundation branch from 739c923 to ea51491 Compare

July 3, 2026 10:33

d-cs marked this pull request as ready for review

July 3, 2026 10:35

This comment was marked as resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          docs(run-ops): add RUN_OPS_DATABASE_URL to .env.example

00cfae3

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

ericallam approved these changes

Jul 3, 2026

View reviewed changes

d-cs merged commit 84588bd into main

Jul 3, 2026

59 checks passed

Uh oh!

There was an error while loading. Please reload this page.

d-cs deleted the runops/pr02-db-foundation branch

July 3, 2026 11:05

d-cs added a commit that referenced this pull request

Jul 3, 2026


          feat(run-ops): cross-producer ClickHouse version helper + cross-Postg…

a93b101

…res-version compat tests (#4114)

## What

- Adds `composeTaskRunVersion` to `@internal/clickhouse` (exported from
the package index). It packs a small `originGeneration` epoch into the
top 8 bits of the ReplacingMergeTree version and keeps the producer's
own LSN in the low 56 bits, so `task_runs_v2` rows replicated from more
than one Postgres producer become globally comparable while preserving
in-producer ordering. Single-producer setups never call it and keep
using the raw LSN version.
- Adds unit coverage for the helper in `taskRuns.test.ts` (bit layout,
ordering, epoch precedence, range validation).
- Adds two run-engine tests that exercise the cross-Postgres-version
testcontainer fixture:
- `heteroPostgresFixture.test.ts` — a smoke test asserting byte-identity
and identical `ORDER BY` (under a pinned ICU collation) across two
different Postgres major versions.
- `crossVersionCompat.test.ts` — mirrors the run-engine's real raw-SQL
surfaces and asserts byte-identical, ordering-identical results across
the two versions. Ships with an env-gated block (skipped by default)
that can be pointed at a real dedicated database in CI.

## Why

Third PR in the run-ops split stack. It is purely additive: it
introduces one new exported helper plus tests and changes no runtime
call sites, so on its own it has no runtime behavior change. It lays
down the version-composition primitive and the cross-version
compatibility proof that later PRs in the stack rely on.

## Tests

- New unit tests for `composeTaskRunVersion` in
`internal-packages/clickhouse/src/taskRuns.test.ts` (run against a real
ClickHouse testcontainer).
- New cross-version tests in
`internal-packages/run-engine/src/engine/tests/` running against real
Postgres containers of two different major versions (no mocks). The
env-gated dedicated-database block is skipped unless its URL is set.

## Notes

Draft, **stacked on #4113** (`runops/pr02-db-foundation`). Review that
first; this diff is against it.

Server-change / changeset note to be added at stack-assembly time.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>

Reviewers

coderabbitai[bot]

coderabbitai[bot] left review comments

devin-ai-integration[bot]

devin-ai-integration[bot] left review comments

ericallam

ericallam approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

d-cs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

d-cs commented Jul 2, 2026

What

Why

Tests

Notes

Uh oh!

changeset-bot Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

pkg-pr-new Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

This comment was marked as resolved.

Uh oh!

d-cs commented Jul 2, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

pkg-pr-new Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.