GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Wrong and confusing type annotations · Issue #318 · uniswap-python/uniswap-python Open Labels bugSomething isn't workingSomething isn't working DescriptionThe wrong type annotation was used in the class Uniswap: """ Wrapper around Uniswap contracts. """ ... def __init__( self, address: Union[AddressLike, str, None], private_key: Optional[str], provider: str = None, web3: Web3 = None, version: int = 1, default_slippage: float = 0.01, use_estimate_gas: bool = True, # use_eip1559: bool = True, factory_contract_addr: str = None, router_contract_addr: str = None, enable_caching: bool = False, ) -> None: ... At the same time, the type annotation format of I suggest changing it to the following: class Uniswap: """ Wrapper around Uniswap contracts. """ ... def __init__( self, address: Optional[Union[AddressLike, str]], private_key: Optional[str], provider: Optional[str] = None, web3: Optional[Web3] = None, version: int = 1, default_slippage: float = 0.01, use_estimate_gas: bool = True, # use_eip1559: bool = True, factory_contract_addr: Optional[str] = None, router_contract_addr: Optional[str] = None, enable_caching: bool = False, ) -> None: ... Also, I noticed that some function parameters/return values also have such annotations. Returns possible Activity
MetadataMetadataAssigneesLabelsbugSomething isn't workingSomething isn't working TypeProjectsMilestoneRelationshipsDevelopmentIssue actions |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |