GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: update web3py to v6, apply no-implicit-optional, misc fixes by ErikBjare · Pull Request #320 · uniswap-python/uniswap-python

Conversation

@ErikBjare

@ErikBjare ErikBjare commented Feb 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #322

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ErikBjare added 2 commits February 24, 2023 20:09
@ErikBjare
build(deps): updated dependencies
b4f0ad3
@ErikBjare
fix: applied no-implicit-optional
38b7870
@ErikBjare ErikBjare mentioned this pull request Feb 24, 2023
Wrong and confusing type annotations #318
Open
@ErikBjare
ErikBjare force-pushed the dev/misc-fixes2 branch from cbfbd0c to f914ca2 Compare February 24, 2023 19:59
@codecov

codecov Bot commented Feb 24, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Patch coverage: 64.28% and project coverage change: -24.29 ⚠️

Comparison is base (da8c7dd) 84.35% compared to head (ece7f1e) 60.07%.

❗ Current head ece7f1e differs from pull request most recent head 1956fec. Consider uploading reports for the commit 1956fec to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #320       +/-   ##
===========================================
- Coverage   84.35%   60.07%   -24.29%     
===========================================
  Files          10       10               
  Lines        1042     1042               
===========================================
- Hits          879      626      -253     
- Misses        163      416      +253
Impacted Files Coverage Δ
uniswap/cli.py 92.95% <0.00%> (ø)
uniswap/tokens.py 64.28% <ø> (-21.43%) ⬇️
uniswap/uniswap.py 53.34% <57.14%> (-28.97%) ⬇️
uniswap/util.py 64.86% <100.00%> (-21.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare
fix: changed to using new names in updated web3py versions
00a97bd
@ErikBjare
ErikBjare force-pushed the dev/misc-fixes2 branch from f914ca2 to 00a97bd Compare February 24, 2023 20:03
@ErikBjare ErikBjare mentioned this pull request Mar 6, 2023
Error importing Uniswap with the latest version of web3.py #322
Closed
@ErikBjare
fix: explicitly set gasPrice for tx's
c358849
@ErikBjare
ErikBjare force-pushed the dev/misc-fixes2 branch from 964c15c to c358849 Compare March 6, 2023 10:38
@ErikBjare ErikBjare mentioned this pull request Mar 28, 2023
fix: ContractFunction in web3.contract is deprecated #326
Closed
ErikBjare added 2 commits March 29, 2023 18:33
@ErikBjare
fix: misc fixes
8625211
@ErikBjare
build(deps): updated dependencies
5fc8110
@ErikBjare

ErikBjare commented Mar 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I'm stumped, I keep getting Revert reason: Not WETH9 for some reason :<

Also, why is CI not running?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ErikBjare
ErikBjare commented Mar 29, 2023
View reviewed changes
Comment thread tests/test_uniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ErikBjare
ErikBjare commented Mar 29, 2023
View reviewed changes
Comment thread uniswap/uniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ErikBjare
ErikBjare commented Mar 29, 2023
View reviewed changes
Comment thread uniswap/uniswap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
ErikBjare
ErikBjare commented Mar 29, 2023
View reviewed changes
Comment thread uniswap/util.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare
ErikBjare requested a review from liquid-8 March 29, 2023 16:42
ErikBjare added 3 commits March 30, 2023 14:53
@ErikBjare
fix: fixed bug caused previously in PR
356e940
@ErikBjare
build(deps): updated dependencies
cb73004
@ErikBjare
ci: added poetry config installer.modern-installation false to work…
27ca688 
… around bug
@ErikBjare
ErikBjare force-pushed the dev/misc-fixes2 branch from 932490b to 27ca688 Compare March 30, 2023 13:01
ErikBjare added 2 commits March 30, 2023 15:06
@ErikBjare
fix: removed unused code
8a96c07
@ErikBjare
ci: fix ci
702419e
@ErikBjare
ErikBjare removed the request for review from liquid-8 March 30, 2023 13:10
@ErikBjare
build(deps): pinned pydata-sphinx-theme to work around bug
ece7f1e
@ErikBjare

ErikBjare commented Mar 30, 2023

Copy link
Copy Markdown
Member Author

Alright, finally done now.

Shipping :shipit:
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare
build(deps): changed version marker for web3
1956fec
@ErikBjare ErikBjare changed the title Misc fixes: update deps, apply no-implicit-optional, updated web3py names fix: update web3py to v6, apply no-implicit-optional, misc fixes Mar 30, 2023
@ErikBjare
ErikBjare merged commit 6ff4539 into master Mar 30, 2023
@ErikBjare ErikBjare mentioned this pull request Mar 30, 2023
'Web3' has no attribute 'toChecksumAddress'. Did you mean: 'to_checksum_address'? #327
Closed
@liquid-8

liquid-8 commented Mar 31, 2023

Copy link
Copy Markdown
Member

I couldn't manage to review it in time; sorry for that. I was going to take a look today. However, I'm glad it is fine now.
ErikBjare reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@piekstra piekstra mentioned this pull request Oct 2, 2026
Modernize: web3 8, Python 3.11+, pyproject packaging, CI, trusted publishing (2.0.0) mine-your-business/myb-uniswap-sdk#5
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error importing Uniswap with the latest version of web3.py

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ErikBjare @liquid-8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.