GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — More helpful error messages for `ContractLogicError: execution reverted` · Issue #356 · uniswap-python/uniswap-python

More helpful error messages for ContractLogicError: execution reverted #356

New issue
Copy link
New issue
Copy link
Open
Open
More helpful error messages for ContractLogicError: execution reverted#356
Copy link
Labels
enhancementNew feature or requestNew feature or request

Description

@ErikBjare
ErikBjare
opened on Nov 1, 2023
Issue body actions

Seems like one of the most commonly reported issue is about passing wrong params:

  • web3.exceptions.ContractLogicError: execution reverted: Unexpected error uniswapv3 EUROC USDC pair #355
  • execution reverted by new coin (even after liquidity added) #350

I suppose these happen if any of (version, fee, token0, token1) are wrong.

It might be helpful to catch these exceptions and re-raise them with more helpful error messages, as I wrote here: #355 (comment)

We might also want to remove the 0.3% assumption and just raise an exception if not set for V3: #355 (comment)

Activity

  1. ErikBjare
    added
    enhancementNew feature or requestNew feature or request
    on Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.