GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: Make fee a required argument with Uniswap V3 by antibagr · Pull Request #358 · uniswap-python/uniswap-python

Conversation

@antibagr

@antibagr antibagr commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Solves #355
Partially solves #356

What's new?

  • uniswap.fee.FeeTier enum added with all available tiers combined
  • InvalidFeeTier raised when Uniswap v3 is used without explicitly providing a fee argument
  • InvalidFeeTier raised when the fee is invalid (not a number, not a FeeTier's member)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
liquid-8 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
antibagr added 4 commits December 4, 2023 18:14
@antibagr
Add FeeTier
c707b70
@antibagr
Add FeeTier tests
e18e01e
@antibagr
Update project version 0.7.0 -> 0.7.1
0c9cd26
@antibagr
Revert several unnecessary changes
9b985f7
@antibagr

antibagr commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Additionally, I updated the changelog and the project's version and added tests for new functionality. Feel free to let me know if any changes are desirable!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@antibagr antibagr changed the title Make fee a required argument with Uniswap V3 fix: Make fee a required argument with Uniswap V3 Dec 4, 2023
@ErikBjare

ErikBjare commented Dec 4, 2023

Copy link
Copy Markdown
Member

Beautiful PR!

Thanks a lot for this. Will give it a final review and merge tomorrow :)
antibagr reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@antibagr
Fix tests
eb744d7
antibagr
antibagr commented Dec 5, 2023
View reviewed changes
Comment thread tests/test_uniswap.py
# ("ETH", "UNI", int(0.000001 * ONE_ETH), ZERO_ADDRESS),
# ("UNI", "ETH", int(0.000001 * ONE_ETH), ZERO_ADDRESS),
# ("DAI", "UNI", int(0.000001 * ONE_ETH), ZERO_ADDRESS),
(

@antibagr antibagr Dec 5, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the failing tests, though I ask you to take a look at the deleted test line. It was failing because InsufficientBalance wasn't raised during the tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ErikBjare ErikBjare Dec 6, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I will add this back in a new PR and sort it out later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
antibagr reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@codecov

codecov Bot commented Dec 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad8c8a1) 83.84% compared to head (eb744d7) 84.20%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   83.84%   84.20%   +0.36%     
==========================================
  Files          10       11       +1     
  Lines        1052     1057       +5     
==========================================
+ Hits          882      890       +8     
+ Misses        170      167       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare

ErikBjare commented Dec 6, 2023

Copy link
Copy Markdown
Member

The Arbitrum test fails due to "rate limit exceeded", which we will ignore, so all is good!

Thanks for your contribution! ❤️
antibagr reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ErikBjare
ErikBjare merged commit cd5d95e into uniswap-python:master Dec 6, 2023
@ErikBjare ErikBjare mentioned this pull request Dec 6, 2023
test: readded failing insufficient balance test #359
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikBjare ErikBjare ErikBjare left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@antibagr @ErikBjare
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.