GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — test: xfail v1 UNI-exchange price-output cases (no liquidity) by TimeToBuildBob · Pull Request #479 · uniswap-python/uniswap-python Conversation
Contributor
ProblemThe FixRuntime Verification
Ref: #478
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
…dJump) The three ETH-UNI / UNI-ETH test_get_price_output parametrizations fail on the v1 mainnet job because the v1 UNI exchange contract has no remaining liquidity and the Vyper bytecode hits EVM error InvalidJump. This is pre-existing (depot unchanged since the branch's first push) and blocks every PR's CI. Runtime-xfail only fires for version==1 UNI pairs; v2/v3 UNI cases keep passing. Git-Session-Id: 3d27
|
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #479 +/- ## ======================================= Coverage 73.26% 73.26% ======================================= Files 12 12 Lines 2319 2319 ======================================= Hits 1699 1699 Misses 620 620 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Greptile SummaryThis PR marks the three V1 UNI exact-output quote cases as expected failures because the liquidity-free legacy exchange reverts on the mainnet fork.
Confidence Score: 5/5The PR appears safe to merge because the new condition covers exactly the documented failing V1 UNI output-price cases. The xfail is restricted by both protocol version and token symbol, while every intercepted parameterization reaches the legacy UNI exchange and previously fails rather than taking the existing unsupported-pair skip. Important Files Changed
Reviews (1): Last reviewed commit: "test: xfail v1 UNI-exchange price-output..." | Re-trigger Greptile |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Friendly ping for review when you get a chance — all 7 checks are green on this one (including the previously-failing v1 mainnet job). Once it merges, PR #478's last red check should resolve on re-run. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Same fix as uniswap-python#479 — the v1 UNI exchange has no remaining liquidity so get_price_output raises EVM error InvalidJump on mainnet fork. Git-Session-Id: 8f77
|
Imo, we can dismiss this issue completely. v1 CI tests are gonna be disabled in the next release because v1 itself is deprecated. There is no reason to maintain that functionality. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Agreed — closing this workaround in favor of removing the deprecated v1 CI coverage in the next release. No need to maintain a separate UNI-exchange xfail. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… grant D3/D4) (#480) * feat(metrics): adoption baseline snapshot script and daily workflow Adds scripts/adoption_snapshot.py (stdlib-only) that captures: - GitHub stars, forks, watchers, open issues - GitHub Traffic: clones/views (14-day window; requires push-access token — the bundled GH Actions workflow captures this automatically) - PyPI downloads last day/week/month (pypistats.org) - Recent release versions and dates Modes: Snapshot (default): emits metrics/adoption-YYYY-MM-DD.{json,md} Report (--report BASELINE.json): prints deltas vs baseline for D4 Also adds .github/workflows/adoption-snapshot.yml (daily at 06:00 UTC) that runs with the repo's GITHUB_TOKEN so traffic data accumulates before the 14-day window rolls off. Initial bootstrap snapshot included (2026-09-02): 1011 stars, 375 forks, 1044 PyPI downloads/month. Per-version download splits require BigQuery (documented in script TODO). Co-authored-by: Erik Bjäreholt <[email protected]> Git-Session-Id: 3b38 * fix(metrics): fail closed on traffic auth and collector errors The default Actions GITHUB_TOKEN cannot read /traffic/* (always 403). The workflow now prefers ADOPTION_GITHUB_TOKEN (PAT), runs --strict so failed/skipped collectors do not commit N/A snapshots, retries 429s, and includes traffic deltas in --report. Push path rebases on conflict. * test: xfail v1 UNI-exchange price-output cases (no liquidity) Same fix as #479 — the v1 UNI exchange has no remaining liquidity so get_price_output raises EVM error InvalidJump on mainnet fork. Git-Session-Id: 8f77 * fix(metrics): reconstruct traffic period totals from daily series GitHub Traffic is a rolling 14-day window, not a cumulative counter. Subtracting two windows produced misleading D4 deltas. Store the daily breakdown (per=day) and union it across snapshots for period clone/view counts. Unique visitors stay point-in-time — they are not additive. * fix(metrics): exclude partial current UTC day from period totals Report mode included today's still-accumulating GitHub Traffic row in D4 period totals, understating clones/views on every 06:00 UTC run. Drop that day from the reconstructed range and label it excluded. * fix(metrics): pin collection clock so midnight cannot include a partial day complete_period_end() re-read datetime.now() after collect_metrics() had already stamped snapshot_at. A report that started before UTC midnight and finished after kept the earlier snapshot day, skipped exclusion, and published that day's still-accumulating Traffic row as a complete total. Use one collected_at for snapshot_at, the filename, and period-end exclusion. When now is omitted, key off the snapshot day rather than a fresh clock. --------- Co-authored-by: Erik Bjäreholt <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.