GeezerVison

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.75%. Comparing base (bd4bd39) to head (17cb97d).

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   70.68%   70.75%   +0.06%     
==========================================
  Files          14       14              
  Lines        4302     4302              
==========================================
+ Hits         3041     3044       +3     
+ Misses       1261     1258       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Brings the async clients in line with the sync arithmetic fixes.

• Async price readers keep tiny token prices instead of rounding them away.
• Async v3 pool totals use half-step bounds for odd ticks.

No actionable issues found. Tests were inspected but not run.

_{Reviews (1) · Last reviewed commit: "fix(async): port price-floor and odd-tic..." · Reviewed by Greptile}

All five CI checks are green, and there are no outstanding review findings or human questions. I have pull-only access here, so merging requires a maintainer. No further code changes made.

@TimeToBuildBob v3 tests don't pass, neither sync nor async, after the merge. Any suggestions? Note that the sync class hasn't been affected.

Looking at the failing CI run, the two failing tests are test_v3_deploy_pool_with_liquidity and test_close_position. Both fail with:

ContractLogicError: execution reverted: STF

"STF" is the Safe Transfer From revert string from Uniswap's NonfungiblePositionManager. It fires when the ERC-20 transferFrom from the test wallet is rejected — most commonly because the wallet's token balance is exhausted or the PositionManager's allowance has run out from a previous test run.

This is not caused by #493. The sync test_v3_deploy_pool_with_liquidity and test_close_position fail with the same error, and my PR only changed arithmetic in the async get_raw_price, get_token_token_spot_price, and get_tvl_in_pool methods — none of which are involved in pool deployment or position closing.

Suggested checks:

1. Replenish the test wallet's DAI and USDC on mainnet (or whichever token the test uses).
2. Re-approve the PositionManager contract (0xC36442b4a4522E871399CD717aBDD847Ab11FE88) for a fresh allowance.
3. If the wallet balance is fine, check whether the pool already exists at the same tick range from a prior run — a reused tick range can cause the mint to revert.

The failing test is in tests/test_asyncuniswap.py:438 (IndexError after the STF revert) and the equivalent sync path, both pre-dating this PR's changes.