GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix typo in advanced_data_comparison.md by kukimik · Pull Request #1171 · utPLSQL/utPLSQL

Conversation

@kukimik

@kukimik kukimik commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

Typo (is -> if). This way the sentence makes some sense to me. Hope I got it right.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jgebal

jgebal commented Dec 6, 2021

Copy link
Copy Markdown
Member

Actually the documentation is correct in current state.
When you use the contain matcher, the order of rows is ignored

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kukimik

kukimik commented Dec 6, 2021

Copy link
Copy Markdown
Contributor Author

Then I'd say the sentence is not clear enough; I'm not able to parse it, and even after your comment I'm not sure what is the meaning of this note. Perhaps it can be reworded?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lwasylow

lwasylow commented Dec 6, 2021

Copy link
Copy Markdown
Member

I guess it could be reworded to say that when using a contain matcher, the order of data is irrelevant and they are compared similar way when unordered matcher is used.
Certainly the word if is not a right one to use it in this scenario in my opinion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kukimik
kukimik force-pushed the patch-1 branch from e945568 to eca2e32 Compare December 17, 2021 21:30
@kukimik

kukimik commented Dec 17, 2021

Copy link
Copy Markdown
Contributor Author

I think I got it. The two lines:

join_by matcher is much faster on performing data comparison, consider using join_by over unordered

and

contain matcher is not considering order of compared data-sets. Using unordered makes no difference (it's default)

are two separate sentences. The first line is missing a period at the end. Am I right?

If so, please check the updated commit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgebal
jgebal requested changes Dec 20, 2021
View reviewed changes
Comment thread docs/userguide/advanced_data_comparison.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

@kukimik
Rewording of a note
99774b9
@kukimik
kukimik force-pushed the patch-1 branch from eca2e32 to 99774b9 Compare December 21, 2021 20:36
@kukimik kukimik mentioned this pull request Dec 22, 2021
Minor typo, style and grammar fixes #1173
Merged
@kukimik
kukimik requested a review from jgebal December 30, 2021 21:24
jgebal
jgebal approved these changes Jan 2, 2022
View reviewed changes
@jgebal
jgebal merged commit 6a0fedc into utPLSQL:develop Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kukimik @jgebal @lwasylow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.