GeezerVison is showing github.com — Minor typo, style and grammar fixes by kukimik · Pull Request #1173 · utPLSQL/utPLSQL
Conversation
This should be less problematic than #1171, I mostly fix obvious typos.
I believe the new note on negating to_contain is in place, as it may be rather surprising that not_to_contain is not a negation of to_contain.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
lwasylow
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most changes look good. Some small issues I'm not sure about.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks for all the improvements
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
lwasylow
lwasylow approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.