GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Feature/add reason to disable by lwasylow · Pull Request #1183 · utPLSQL/utPLSQL Conversation
|
Unit Test Results 1 files 2 suites 1m 38s ⏱️ Results for commit c762920. ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@ ## develop #1183 +/- ## =========================================== - Coverage 94.86% 94.80% -0.07% =========================================== Files 104 104 Lines 4853 4886 +33 Branches 21 23 +2 =========================================== + Hits 4604 4632 +28 - Misses 241 245 +4 - Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
We need to also update other reporters except ut_documentation_reporter
Particularly:
ut_junit_reporter - tag <skipper>reason</skipped>ut_tfs_junit_reporter - tag <skipper>reason</skipped>For the ut_realtime_reporter - It would be good to check with @PhilippSalvisberg
For the ut_teamcity_reporter - I'm not sure if the format supports a disabled/skipped description. The format description can be found here.
I didn't run utPLSQL on TeamCity for a long time and don't have local setup ready.
You would need to install and run TeamCity build locally (docker?) to actually test it.
Update
I've checked the documentation and the disabled (ignored) description is supported in TeamCity:
##teamcity[testIgnored name='testName' message='ignore comment']
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
I don't think this information is required for the realtime reporter. If you decide to add it, it will not have any effect. The SQLDev extension and the PL/SQL Developer plugin will ignore this additional information. If you think the behaviour in the IDE should change then I suggest to open dedicated issues for SQLDev and PL/SQL Developer. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@lwasylow @simasch |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
So personally I think if we want to have that feature enabled it makes sense to be consistent. I think it's useful piece of information. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
As mentioned before, you can include it if you want. The SQLDev extension and the PL/SQL Dev plugin will work without any change since they just pick the information from the XML events they need. I suggest to open dedicated issues for the IDEs. I think the commercial tools TOAD and DataGrip do not use the realtime reporter. However, if the reason for a disabled test should be displayed in the test runner they need to change something as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Here are results for as per documentation
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
If created a feature request for the PL/SQL Developer plugin utPLSQL/utPLSQL-PLSQL-Developer#25 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Kudos, SonarCloud Quality Gate passed! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Add support forreason in the --%disabled annotation
There was an error while loading. Please reload this page.