GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feature/add reason to disable by lwasylow · Pull Request #1183 · utPLSQL/utPLSQL

Conversation

@lwasylow

@lwasylow lwasylow commented Feb 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Adding option to put a reason for disabling tests.
CLOSES #610

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
lwasylow added 3 commits February 6, 2022 15:49
@lwasylow
Update code.
987d391
@lwasylow
Updating testss
fddde60
@lwasylow
Merge branch 'develop' of https://github.com/utPLSQL/utPLSQL into fea…
ca227c0
…ture/add_reason_to_disable
@lwasylow
lwasylow requested review from jgebal and pesse and removed request for jgebal February 6, 2022 17:40
@lwasylow lwasylow linked an issue Feb 6, 2022 that may be closed by this pull request
Add support for reason in the --%disabled annotation #610
Closed
@github-actions

github-actions Bot commented Feb 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files         2 suites   1m 38s ⏱️
1 029 tests 1 025 ✔️ 4 💤 0 ❌
1 032 runs  1 024 ✔️ 8 💤 0 ❌

Results for commit c762920.

♻️ This comment has been updated with latest results.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Feb 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Merging #1183 (c762920) into develop (ab1acfa) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1183      +/-   ##
===========================================
- Coverage    94.86%   94.80%   -0.07%     
===========================================
  Files          104      104              
  Lines         4853     4886      +33     
  Branches        21       23       +2     
===========================================
+ Hits          4604     4632      +28     
- Misses         241      245       +4     
- Partials         8        9       +1     
Flag Coverage Δ
11xe 94.22% <100.00%> (+0.04%) ⬆️
18xe 94.44% <100.00%> (-0.09%) ⬇️
21xe 94.62% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/core/types/ut_run.tpb 93.93% <ø> (ø)
source/core/ut_suite_cache_manager.pkb 97.01% <ø> (ø)
source/core/ut_suite_manager.pkb 95.81% <ø> (ø)
source/core/ut_utils.pkb 94.19% <ø> (ø)
source/api/ut_suite_item_info.tpb 100.00% <100.00%> (ø)
source/core/types/ut_logical_suite.tpb 100.00% <100.00%> (ø)
source/core/types/ut_suite.tpb 100.00% <100.00%> (ø)
source/core/types/ut_suite_item.tpb 100.00% <100.00%> (ø)
source/core/types/ut_test.tpb 100.00% <100.00%> (ø)
source/core/ut_suite_builder.pkb 99.69% <100.00%> (+<0.01%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bb27b...c762920. Read the comment docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lwasylow
lwasylow requested a review from jgebal February 6, 2022 18:01
jgebal
jgebal reviewed Feb 6, 2022
View reviewed changes

@jgebal jgebal left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also update other reporters except ut_documentation_reporter
Particularly:

  • ut_junit_reporter - tag <skipper>reason</skipped>
  • ut_tfs_junit_reporter - tag <skipper>reason</skipped>

For the ut_realtime_reporter - It would be good to check with @PhilippSalvisberg
For the ut_teamcity_reporter - I'm not sure if the format supports a disabled/skipped description. The format description can be found here.
I didn't run utPLSQL on TeamCity for a long time and don't have local setup ready.
You would need to install and run TeamCity build locally (docker?) to actually test it.

Update
I've checked the documentation and the disabled (ignored) description is supported in TeamCity:

##teamcity[testIgnored name='testName' message='ignore comment']

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread source/core/ut_suite_builder.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread source/core/ut_suite_builder.pkb Resolved

Uh oh!

There was an error while loading. Please reload this page.

@PhilippSalvisberg

PhilippSalvisberg commented Feb 6, 2022

Copy link
Copy Markdown
Member

We need to also update other reporters except ut_documentation_reporter Particularly:
(...)
For the ut_realtime_reporter - It would be good to check with @PhilippSalvisberg

I don't think this information is required for the realtime reporter. If you decide to add it, it will not have any effect. The SQLDev extension and the PL/SQL Developer plugin will ignore this additional information. If you think the behaviour in the IDE should change then I suggest to open dedicated issues for SQLDev and PL/SQL Developer.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jgebal

jgebal commented Feb 6, 2022

Copy link
Copy Markdown
Member

@lwasylow @simasch
Not sure what are your thoughts on having disabled reason visible in SQL/PLSQL Developer IDE.
I think it would be a good to have a complete feature and similar behaviour across all use-cases & IDEs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jgebal jgebal added this to the 3.1.12 milestone Feb 6, 2022
@lwasylow
Resolving a code comments
79da316
@lwasylow

lwasylow commented Feb 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@lwasylow @simasch Not sure what are your thoughts on having disabled reason visible in SQL/PLSQL Developer IDE. I think it would be a good to have a complete feature and similar behaviour across all use-cases & IDEs.

So personally I think if we want to have that feature enabled it makes sense to be consistent. I think it's useful piece of information.
However lets hold on with making that call to see if other reporters support the reason of disabling.
I don't think it should hold up release of that feature as we can stage it given a dependency between objects and time needed for @PhilippSalvisberg @simasch to give us specs ( and I mean their personal time :) ) but would ultimate aim for that to be included?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@PhilippSalvisberg

PhilippSalvisberg commented Feb 7, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@lwasylow @simasch Not sure what are your thoughts on having disabled reason visible in SQL/PLSQL Developer IDE. I think it would be a good to have a complete feature and similar behaviour across all use-cases & IDEs.

So personally I think if we want to have that feature enabled it makes sense to be consistent. I think it's useful piece of information. However lets hold on with making that call to see if other reporters support the reason of disabling. I don't think it should hold up release of that feature as we can stage it given a dependency between objects and time needed for @PhilippSalvisberg @simasch to give us specs ( and I mean their personal time :) ) but would ultimate aim for that to be included?

As mentioned before, you can include it if you want. The SQLDev extension and the PL/SQL Dev plugin will work without any change since they just pick the information from the XML events they need. I suggest to open dedicated issues for the IDEs. I think the commercial tools TOAD and DataGrip do not use the realtime reporter. However, if the reason for a disabled test should be displayed in the test runner they need to change something as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lwasylow

lwasylow commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

Please see snippet from junit reporter.
image

jgebal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lwasylow

lwasylow commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

Here are results for ut_tfs_junit_reporter
image

as per documentation

Error message /Testsuites/testsuite/testcase/failure.Attributes["message"].Value Or /Testsuites/testsuite/testcase/error.Attributes["message"].Value Or /Testsuites/testsuite/testcase/skipped.Attributes["message"].Value
jgebal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@simasch

simasch commented Feb 7, 2022

Copy link
Copy Markdown
Member

If created a feature request for the PL/SQL Developer plugin utPLSQL/utPLSQL-PLSQL-Developer#25

lwasylow and jgebal reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@lwasylow

lwasylow commented Feb 7, 2022

Copy link
Copy Markdown
Member Author

Here results for ut_teamcity_reporter
image

jgebal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lwasylow added 3 commits February 7, 2022 13:32
@lwasylow
Updating reporters
ed156d7
@lwasylow
Updates to junit xsd
2ea9a53
@lwasylow
Update coverage
78cfb83
@jgebal jgebal mentioned this pull request Feb 7, 2022
Add support for disabled reason with utPLSQL v3.1.12 utPLSQL/utPLSQL-SQLDeveloper#143
Closed
@lwasylow
Update sonar
c762920
@lwasylow
lwasylow requested a review from jgebal February 8, 2022 12:01
@sonarqubecloud

sonarqubecloud Bot commented Feb 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.7% 0.7% Duplication

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jgebal
jgebal approved these changes Feb 8, 2022
View reviewed changes
@lwasylow
lwasylow merged commit 62716ae into develop Feb 8, 2022
@lwasylow
lwasylow deleted the feature/add_reason_to_disable branch February 8, 2022 12:55
@PhilippSalvisberg PhilippSalvisberg mentioned this pull request Feb 25, 2022
Extend ut_realtime_reporter to include disabled reason #1192
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal jgebal approved these changes
@pesse pesse Awaiting requested review from pesse

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.1.12

Development

Successfully merging this pull request may close these issues.

Add support for reason in the --%disabled annotation

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@lwasylow @PhilippSalvisberg @jgebal @simasch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.