GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Creating a list of annotations allowed to treat package as annotated by lwasylow · Pull Request #1297 · utPLSQL/utPLSQL

Conversation

@lwasylow

@lwasylow lwasylow commented Apr 10, 2025

Copy link
Copy Markdown
Member

Resolve #1278

Root problem is the issue that package is being treated as annotate which allows it to be pushed into cache_suite table.
The solution is the do not treat object as annotated if the --% does not contain a valid annotation that is specified by framework.
e.g. ignore comments like --%parameter

This will allow for greater flexibility for documenting.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lwasylow added 4 commits April 4, 2025 19:47
@lwasylow
Creating a list of annotations allowed.
aa400a4 
Current issues is that any comment matching annotation --% is pushed into ut cache packages which causes exclusion from coverage reports.
@lwasylow
Remove debug
0e2efab
@lwasylow
Merge branch 'develop' of https://github.com/utPLSQL/utPLSQL into fea…
ed6307b 
…ture/issue_1278
@lwasylow
Updating a regex to treat object as annotated only if it contains val…
b8e9c31 
…id annotations.
@github-actions

github-actions Bot commented Apr 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Unit Test Results

       1 files  ±  0         2 suites  ±0   2m 40s ⏱️ -48s
1 084 tests +26  1 080 ✔️ +26  4 💤 ±0  0 ❌ ±0 
1 088 runs  +26  1 080 ✔️ +26  8 💤 ±0  0 ❌ ±0 

Results for commit 463b84b. ± Comparison against base commit e872b30.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lwasylow
Remove empty line
463b84b
@lwasylow
lwasylow requested a review from jgebal April 10, 2025 19:41
@codecov

codecov Bot commented Apr 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.05%. Comparing base (45e3b57) to head (439d9be).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1297   +/-   ##
========================================
  Coverage    95.04%   95.05%           
========================================
  Files          111      111           
  Lines         5369     5377    +8     
  Branches        33       33           
========================================
+ Hits          5103     5111    +8     
  Misses         266      266
Flag Coverage Δ
19se 95.10% <100.00%> (+<0.01%) ⬆️
21XE 95.25% <100.00%> (+<0.01%) ⬆️
23-free 94.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lwasylow
Merge branch 'develop' of https://github.com/utPLSQL/utPLSQL into fea…
439d9be 
…ture/issue_1278
@github-actions

github-actions Bot commented Mar 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

    1 files    103 suites   2m 32s ⏱️
1 091 tests 1 087 ✅ 4 💤 0 ❌
1 095 runs  1 087 ✅ 8 💤 0 ❌

Results for commit 439d9be.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sonarqubecloud

sonarqubecloud Bot commented Mar 9, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal

jgebal commented Mar 15, 2026

Copy link
Copy Markdown
Member

This is not the correct way to solve this problem.
Annotation parsing must remain independent of suites.
This is by design.

There was an actual issue (A bug) in the suite cache management (not annotation cache)

I opened a separate PR to solve this problem. See #1313
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal jgebal closed this Mar 15, 2026
@jgebal
jgebal deleted the feature/issue_1278 branch October 2, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgebal jgebal Awaiting requested review from jgebal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Coverage not being reported when comment starts with --%param

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@lwasylow @jgebal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.