GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Suite cache should not be saved for packages that are not suites by jgebal · Pull Request #1313 · utPLSQL/utPLSQL

Conversation

@jgebal

@jgebal jgebal commented Mar 15, 2026

Copy link
Copy Markdown
Member

There was a bug in ut_suite_cache_manager that was causing packages that had comments captured as annotations ( the --%) to be saved in suite cache and considered as test suites.
Those packages were then getting excluded form coverage report.

Only packages that contain suite information should be considered test suites and should eb added to suite cahge.
The annotation parsing remains independent from suite constriction and therefore all lines with comment --% are still saved in annotation cache.

Resolves #1278

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jacek Gębal
Added tests to reproduce the issue.
2c8811d
@github-actions

github-actions Bot commented Mar 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Test Results

    1 files    102 suites   2m 31s ⏱️
1 090 tests 1 086 ✅ 4 💤 0 ❌
1 094 runs  1 086 ✅ 8 💤 0 ❌

Results for commit f3c0d3f.

♻️ This comment has been updated with latest results.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal jgebal mentioned this pull request Mar 15, 2026
Creating a list of annotations allowed to treat package as annotated #1297
Closed
Jacek Gębal
Fixed the problem where suite_cache_package and `suite_cache_schema…
f3c0d3f 
…` are getting populated even package is not a suite.
@sonarqubecloud

sonarqubecloud Bot commented Mar 15, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Mar 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.08%. Comparing base (c243e4e) to head (f3c0d3f).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1313      +/-   ##
===========================================
+ Coverage    95.04%   95.08%   +0.03%     
===========================================
  Files          111      111              
  Lines         5369     5369              
  Branches        33       33              
===========================================
+ Hits          5103     5105       +2     
+ Misses         266      264       -2
Flag Coverage Δ
19se 95.13% <100.00%> (+0.03%) ⬆️
21XE 95.28% <100.00%> (+0.03%) ⬆️
23-free 95.02% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
jgebal requested a review from lwasylow March 15, 2026 11:28
lwasylow
lwasylow approved these changes Mar 15, 2026
View reviewed changes
@jgebal
jgebal merged commit d7c0005 into develop Mar 15, 2026
17 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@jgebal
jgebal deleted the bugfix/suite_cache_populated_for_non_suites_1278 branch March 15, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwasylow lwasylow lwasylow approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Coverage not being reported when comment starts with --%param

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@jgebal @lwasylow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.