GeezerVison is showing github.com — Code coverage is not working properly · Issue #99 · utPLSQL/utPLSQL-SQLDeveloper
Code coverage is not working properly #99DescriptionHi,
When I right click on a specific package/procedure/function and try to run code coverage, it does not do anything.
Code coverage is only working when I select the whole DB.
Is this behaviour intentional?
I tried with SQLDeveloper v19.4.0 extension v1.1.0 and 1.1.1.
Thanks,
Imre ActivityPhilippSalvisberg commented on Apr 27, 2020 Hi @horimre,
I've installed plscope-utils and then right-clicked on plscope.test_lineage_util and got this dialog:
and then pressed Run and after a moment the following result was shown in my browser:
So, it should work to run code coverage for single test package only. And it should work for multiple test packages as well.
I've used Oracle Database 19.7. But it should work also in 12.2.
What do you mean with
it does not do anything?
No dialog? No result? both? Does Run utPLSQL test work for the same test package?
Thanks,
Philipp horimre commented on Apr 27, 2020 Hi,
There is no dialog, and no result.
After I click Code coverage... the context menu just disappears.
Run utPLSQL test is working for the same package.
Maybe the issue is that we have a very old utPLSQL install on the DB. It is v3.1.9.3270.
I am using Oracle Database 18c.
Thanks,
Imre PhilippSalvisberg commented on Apr 27, 2020 Thanks for the details. utPLSQL v3.1.9 is good enough. That should not be the problem.
And it's working when you run it from the connection or package node, right? horimre commented on Apr 27, 2020 Right, it is working when I run it from the connection. The dialog shows up I can run it and see the report. PhilippSalvisberg commented on Apr 27, 2020 Could you please run the following query?
Please amend the lines commented with --2) and --3) and run it with all_dependencies in case it fails with dba_dependencies.
select referenced_owner || '.' || referenced_name AS dep_name
from dba_dependencies -- 1) dba_ or all_
WHERE owner = upper('PLSCOPE') -- 2) owner
AND name = upper('TEST_LINEAGE_UTIL') -- 3) test package name
AND referenced_owner NOT IN (
'SYS', 'SYSTEM', 'XS$NULL', 'OJVMSYS', 'LBACSYS', 'OUTLN', 'SYS$UMF',
'DBSNMP', 'APPQOSSYS', 'DBSFWUSER', 'GGSYS', 'ANONYMOUS', 'CTXSYS',
'SI_INFORMTN_SCHEMA', 'DVF', 'DVSYS', 'GSMADMIN_INTERNAL', 'ORDPLUGINS',
'MDSYS', 'OLAPSYS', 'ORDDATA', 'XDB', 'WMSYS', 'ORDSYS', 'GSMCATUSER',
'MDDATA', 'REMOTE_SCHEDULER_AGENT', 'SYSBACKUP', 'GSMUSER', 'APEX_PUBLIC_USER',
'SYSRAC', 'AUDSYS', 'DIP', 'SYSKM', 'ORACLE_OCM', 'APEX_INSTANCE_ADMIN_USER',
'SYSDG', 'FLOWS_FILES', 'ORDS_METADATA', 'ORDS_PUBLIC_USER'
)
AND referenced_owner NOT LIKE 'APEX\_______'
AND referenced_type IN ('PACKAGE', 'TYPE', 'PROCEDURE', 'FUNCTION', 'TRIGGER');
Please let me know your database version as well and if you are running it in a PDB.
Thank you. horimre commented on Apr 27, 2020 DEP_NAME
UTPLSQL.UT_EXPECTATION
USER1.TEST_PKG
USER1.TEST_PKG_UT
Oracle Database 18c (18.0.0.0.0), running it in a PDB. PhilippSalvisberg commented on Apr 27, 2020 Thanks. And, does the query work? horimre commented on Apr 27, 2020 yes, that is the result of the query:
DEP_NAME
UTPLSQL.UT_EXPECTATION
USER1.TEST_PKG
USER1.TEST_PKG_UT horimre commented on Apr 27, 2020 Nevermind, this must be some sort of setup issue on my side. The result and runtime should be the same when I run it from the connection and provide the package name in the include objects section. I'll just keep running it that way. PhilippSalvisberg commented on Apr 27, 2020 Yes, that's a workaround.
However, I consider it a bug, when the code coverage dialog does not show up when called from a test package node. To fix it, we have to reproduce it.
Could you please open View -> Log and check if there is a utPLSQL related error message in the Logging Page tab? horimre commented on Apr 28, 2020 There is no error message in the log. It is empty.
Code coverage is also working when I run it from the Packages node.
Btw, I am using jdk1.8.0_241. PhilippSalvisberg commented on Apr 29, 2020 That's strange. I check the accessibility to dba_ views with the following query:
SELECT 1
FROM dba_objects
WHERE 1=2
If the query fails with an exception then all_ views are used, otherwise dba_views.
Does this query work with the user you are testing? I mean access to dba_objects are allowed but access to dba_depencencies are not? horimre commented on Apr 29, 2020 Yes, exactly. The user I am using can access dba_objects, but not dba_dependencies.
Okay, so we have a strange setup then. It is not really a bug.
I know it is a very rare case, but what if you handle this exception and try to query all_dependencies in this case. PhilippSalvisberg commented on Apr 29, 2020 Ok, thank you for the feedback. Happy we found the culprit. The check is a bit naïve, so I have to improve it. I'll read the documentation and think about a good alternative.
The dba_ views are faster (less security checks) that's why we try to use them, if possible. But in the end such an optimization must not lead to a loss of service as in this case.
I'll look into it later this evening and will update this issue. horimre commented on Apr 29, 2020 added a commit that references this issue on Apr 29, 2020This issue will close once commit f6fbba0 is merged into the 'main' branch.f6fbba0 PhilippSalvisberg commented on Apr 29, 2020 horimre commented on Apr 29, 2020 @PhilippSalvisberg it is working now, thank you! 🙂
The code coverage is running for a very long time though.
I have created a package which contains a dummy function (adds 1 to a number parameter and returns the result) then created a test package with a single unit test for the function.
It took 30 seconds for the dialog to pop up and approx 4-5mins for the coverage to finish and display the results.
I have also tried to run it from sql instead of using the extension, but it also took approximately 3 minutes to finish. I used the below commands.
set serveroutput on;
begin
ut.run(
ut_coverage_html_reporter(),
a_include_objects => ut_varchar2_list('test_pkg')
);
end;
/
I am sure it is partly because my environment is a bit slow.
Is the performance better for you?
Thanks,
Imre PhilippSalvisberg commented on Apr 29, 2020
Is the performance better for you?
Yes. As you see in the logs (it contains also my time to click on the Run button):
2020-04-29 22:43:06.272 FINER org.utplsql.sqldev.menu.UtplsqlController: handle utplsql.coverage
2020-04-29 22:43:06.272 FINER org.utplsql.sqldev.menu.UtplsqlController: Code coverage from view oracle.dbtools.raptor.navigator.db.DBNavigatorWindow and node oracle.dbtools.raptor.navigator.plsql.PlSqlNode.
2020-04-29 22:43:06.273 FINER org.utplsql.sqldev.menu.UtplsqlController: Code coverage from DB navigator
2020-04-29 22:43:06.273 FINE org.utplsql.sqldev.menu.UtplsqlController: url: sqldev.nav:IdeConnections%2523plscope-odb-macphs//PLSCOPE/PACKAGE/TEST_LINEAGE_UTIL
2020-04-29 22:43:06.273 FINE org.utplsql.sqldev.menu.UtplsqlController: connectionName: IdeConnections#plscope-odb-macphs
2020-04-29 22:43:06.273 FINE org.utplsql.sqldev.menu.UtplsqlController: path: PLSCOPE.TEST_LINEAGE_UTIL
2020-04-29 22:43:06.273 FINER org.utplsql.sqldev.menu.UtplsqlController: pathList: [PLSCOPE.TEST_LINEAGE_UTIL]
2020-04-29 22:43:06.358 FINER org.utplsql.sqldev.menu.UtplsqlController: includeObjectList: [PLSCOPE.COL_LINEAGE_TYPE, PLSCOPE.COL_TYPE, PLSCOPE.LINEAGE_UTIL, PLSCOPE.TEST_LINEAGE_UTIL, PLSCOPE.T_COL_LINEAGE_TYPE, PLSCOPE.T_COL_TYPE, UT3.UT_EXPECTATION, UT3.UT_EXPECTATION_COMPOUND]
2020-04-29 22:43:06.594 FINER org.utplsql.sqldev.menu.UtplsqlController: showing code coverage dialog
2020-04-29 22:43:06.594 FINER org.utplsql.sqldev.menu.UtplsqlController: code coverage dialog shown
2020-04-29 22:43:07.768 FINE org.utplsql.sqldev.coverage.CodeCoverageReporter: Running code coverage reporter for [PLSCOPE.TEST_LINEAGE_UTIL]...
2020-04-29 22:43:08.457 FINE org.utplsql.sqldev.coverage.CodeCoverageReporter: Writing result to /var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/utplsql_9152831904887327166.html...
2020-04-29 22:43:08.459 FINE org.utplsql.sqldev.coverage.CodeCoverageReporter: Opening file:/var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/utplsql_9152831904887327166.html in browser...
2020-04-29 22:43:08.496 FINE org.utplsql.sqldev.coverage.CodeCoverageReporter: file:/var/folders/lf/8g3r0ts900gfdfn2xxkn9yz00000gn/T/utplsql_9152831904887327166.html opened in browser.
One thing is for sure the access to the all_ views instead of the dba_ views. Ensure you get access to
- dba_objects
- dba_synonyms
- dba_dependencies
and you will experience better performance. I suggest to get the grants.
Look at the statement logs. SQL Developer logs every statement with the time it took. It should reveal the culprit and you should get a better idea where having access to the dba_ views is beneficial.
When the code coverage is slow in the worksheet as well, then the issue is not related to the SQL Developer extension.
Since, the original issue (code coverage not working from a test package node) is solved, I'm going to close this issue.
Thanks for reporting this bug and your help in finding the cause. horimre commented on Apr 29, 2020 sure, thank you for fixing the issue in such a short time, and for your advices on performance as well!
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|
