GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — #64 - Improve error handling when no utPLSQL is installed by PhilippSalvisberg · Pull Request #68 · utPLSQL/utPLSQL-SQLDeveloper

Conversation

@PhilippSalvisberg

@PhilippSalvisberg PhilippSalvisberg commented Jul 13, 2019

Copy link
Copy Markdown
Member

Run worksheet runner when no utPLSQL is installed in the database.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
PhilippSalvisberg added 3 commits July 13, 2019 11:41
@PhilippSalvisberg
change to snapshot version 1.1.0-SNAPSHOT
cc76849
@PhilippSalvisberg
getUtPlsqlVersion does not fail when utplsql is not installed
4b2e3ac
returns a version null in this case, which is later converted
to 0.0.0, which is not a supported version for this extension and
not a supported version for the realtime reporter, hence calling
the runner leads to a use of the worksheet runner regardless of
the utPLSQL configuration.
@PhilippSalvisberg
testing if normalizedUtPlsqlVersion returns a not null value
66be251
This test should succeed on a database without having utplsql
installed. However, the test suite is not enhanced to work
against a database without utplsql, that's simply not worth
the effort.
@PhilippSalvisberg PhilippSalvisberg added the enhancement label Jul 13, 2019
@PhilippSalvisberg PhilippSalvisberg added this to the v1.1.0 milestone Jul 13, 2019
@PhilippSalvisberg
PhilippSalvisberg merged commit e8130c6 into utPLSQL:master Jul 13, 2019
@PhilippSalvisberg
PhilippSalvisberg deleted the feature/issue_64_no_utplsql branch August 18, 2019 15:13
@PhilippSalvisberg PhilippSalvisberg removed this from the v1.1.0 milestone Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@PhilippSalvisberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.