GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cmp Feat: change data type for 'bytes' limit and 'ignore initial' to u64 by GunterSchmidt · Pull Request #183 · uutils/diffutils

Conversation

@GunterSchmidt

@GunterSchmidt GunterSchmidt commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

feat: u64 for --bytes and --ignore-initial
fix: bumped up tempfile to "3.26.0"

The variables for --bytes, --ignore-initial and line count where size 'usize', thus limiting the readable bytes on 32-bit systems. GNU cmp is compiled with LFS (Large File Support) and allows i64 values.

This is now all u64, which works also on 32-bit systems with Rust. There is no reason to implement a 32-bit barrier for 32 bit machines.

Additionally the --bytes limit can be set to 'u128' using the feature "cmp_bytes_limit_128_bit".

The performance impact would be negligible, as there only few calculations each time a full block is read from the file.

This makes PR #172 obsolete.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Gunter Schmidt added 2 commits March 1, 2026 22:37
Gunter Schmidt
feat: u64 for --bytes and --ignore-initial
d0c0611
fix: bumped up tempfile to "3.26.0"

The variables for --bytes, --ignore-initial and line count where size 'usize',
thus limiting the readable bytes on 32-bit systems.
GNU cmp is compiled with LFS (Large File Support) and allows i64 values.

This is now all u64, which works also on 32-bit systems with Rust.
There is no reason to implement a 32-bit barrier for 32 bit machines.

Additionally the --bytes limit can be set to 'u128' using the feature
"cmp_bytes_limit_128_bit".

The performance impact would be negligible, as there only few calculations
each time a full block is read from the file.
Gunter Schmidt
fix: removed 32-bit conditional compiling
884edb2
This was referenced Mar 1, 2026
cmp: Unnecessary use of usize for --bytes limit and --ignore-inital values #184
Closed
Build fails on armv7 musl #172
Closed
Gunter Schmidt
fix: clippy warning
2e9d395
@GunterSchmidt

GunterSchmidt commented Mar 2, 2026

Copy link
Copy Markdown
Contributor Author

Fixed clippy warning.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Gunter Schmidt
removed feature for 128 bit
b1f0166
u64 seems the max file size with Rust, which is an Exabyte.

Renamed type to Skip as this seems preferred.
@GunterSchmidt GunterSchmidt changed the title cmp Feat: change data type bytes limit to u64/u128 ignore initial u64 cmp Feat: change data type for 'bytes' limit and 'ignore initial' to u64 Mar 5, 2026
Gunter Schmidt and others added 4 commits March 5, 2026 14:06
Gunter Schmidt
removed feature for 128 bit, cargo.toml
27c3854
@sylvestre
Merge branch 'main' into feat-cmp--change-data-type---bytes-limit-to-…
1af7733
…u64/u128---ignore-initial--u64
@GunterSchmidt
Merge branch 'uutils:main' into feat-cmp--change-data-type---bytes-li…
b8a6f41
…mit-to-u64/u128---ignore-initial--u64
@GunterSchmidt
Merge branch 'uutils:main' into feat-cmp--change-data-type---bytes-li…
fbb69a9
…mit-to-u64/u128---ignore-initial--u64
@GunterSchmidt GunterSchmidt mentioned this pull request Mar 13, 2026
Breaking: Adapt coreutils dev file structure #201
Closed
@sylvestre
sylvestre merged commit d33aca1 into uutils:main May 14, 2026
28 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@BrewTestBot BrewTestBot mentioned this pull request Oct 23, 2026
uutils-diffutils 0.6.0 Homebrew/homebrew-core#320660
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@GunterSchmidt @sylvestre
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.