GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — Breaking: Adapt coreutils dev file structure by GunterSchmidt · Pull Request #201 · uutils/diffutils Conversation
Contributor
Adapting the project structure to the coreutils structure. coreutils uses a source code tree, which has each tool in a separate dir unter /uu, Adaptiong this structure allows more usage of the coreutils macros Each utility can now be opened standalone Since it is a file location restructure, the commit is containing Changes:
Issues:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionscoreutils structure. This allows more usage of the coreutils macros and is easier for the developers if working in both projects. Each utility can now be opened standalone which makes it also easier to test and benchmark. Since it is a restructure, the commit is containing a lot of files. All files were kept as much as possible and mostly the import locations were changed. Changes: * a workspace was introduced * main.rs is now /bin/diffutils.rs * uumain is now used as start of utility * all utilites have a separate folder under /uu * Exitcodes are now i32 and push to * coreutils only has License files for MIT * args are now read by using uucore::args_os() * context_diff and unified_diff now use TempDir * benches are separated for each utility and have centralized support functions Issues: * The uucore::bin! macro needs to be implemented for all main functions. Currently missing internationalization. * Tests must be run with "cargo test --workspace". * Unclear, if features can be defined globally.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
This is my view on what are the next steps:
So my suggestion in short: Merge #192 first, then #201. Then fix test errors and go from there. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
* fix prg name and parameters * added feature to enable some benches as they should not run during github checks
The tool dist does not allow different repository names within the workspace.
* Replaces PR uutils#144 and PR uutils#145
|
Replaced by PR #206 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #201 +/- ## =========================== =========================== ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.