GeezerVison

Could you please add tests

Thanks

Okay! The current tests are failing.

error: test failed, to rerun pass `--lib`
---- context_diff::tests::test_permutations_missing_lines stdout ----
thread 'context_diff::tests::test_permutations_missing_lines' panicked at src/context_diff.rs:269:44:
Failed to get metadata: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- context_diff::tests::test_permutations_empty_lines stdout ----
thread 'context_diff::tests::test_permutations_empty_lines' panicked at src/context_diff.rs:269:44:
Failed to get metadata: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- context_diff::tests::test_permutations stdout ----
thread 'context_diff::tests::test_permutations' panicked at src/context_diff.rs:269:44:
Failed to get metadata: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- context_diff::tests::test_permutations_reverse stdout ----
thread 'context_diff::tests::test_permutations_reverse' panicked at src/context_diff.rs:269:44:
Failed to get metadata: Os { code: 2, kind: NotFound, message: "No such file or directory" }

---- context_diff::tests::test_stop_early stdout ----
thread 'context_diff::tests::test_stop_early' panicked at src/context_diff.rs:269:44:
Failed to get metadata: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Isn't this strange? We check if file exists in main.rs : https://github.com/uutils/diffutils/blob/main/src/main.rs#L52

Edit: These are unit tests. My bad!

Could you please add tests

Can you guide me more on these 😅?
Current tests are quite difficult to understand

This one is pretty simple, no ? :)
https://github.com/uutils/diffutils/blob/main/tests/integration.rs#L127-L148

@sylvestre I was looking at the unit tests and I see we are not actually creating files but only passing filename literals to context_diff::diff. The tests are failing since we are looking for metadata for files which don't exist in the diff function. We are using expected_filename/actual_filename only for printing.
Should we create those files during the tests?

yes please :)

I'm not sure on how the tests are failing on CI, we are creating the files now. It should have worked. Strange 🤔

The tests are working fine on my machine:

test context_diff::tests::test_permutations_missing_lines ... ok
test context_diff::tests::test_permutations_empty_lines ... ok
test context_diff::tests::test_permutations_reverse ... ok
test context_diff::tests::test_permutations ... ok
test normal_diff::tests::test_stop_early ... ok

sorry, could you please fix the conflict? Sorry :(

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (be66ff3) to head (5b814f8).

❗ Current head 5b814f8 differs from pull request most recent head aedd068. Consider uploading reports for the commit aedd068 to get more accurate results

@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   76.29%   75.85%   -0.45%     
==========================================
  Files           9        9              
  Lines        2582     2597      +15     
  Branches      663      662       -1     
==========================================
  Hits         1970     1970              
- Misses        459      476      +17     
+ Partials      153      151       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I realized that the tests were passing locally because files were generated during previous test runs.
wondering if cargo should clean up the temp files generated during tests 🤔 . Is there any way to specify it? OR we should manually delete them after every unit test.

Is there any way to specify it?

Yeah, just https://crates.io/crates/tempfile to create these files

Hey @oSoMoN , I have made the necessary changes! Can you review the MR?
Thanks!

Halfway through the changes. I'll complete them shortly!

It's worth noting that with the changes in this PR, one test from the GNU test suite which currently fails in main now passes (the timezone test). Nice improvement!

Done!

Sorry for the noise! I forgot to run cargo fmt.

Merged, thanks Tanmay for the contribution!