GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — diff: cut the -p/-F function line at 40 bytes and trim vertical tabs by binhvq · Pull Request #375 · uutils/diffutils

Conversation

@binhvq

@binhvq binhvq commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #359.

The function line after a hunk header was cut at 40 characters instead of 40 bytes, and a leading or trailing \v was kept because trim_ascii_* doesn't treat it as white space.

Now: skip leading white space, keep at most 40 bytes, drop trailing white space, with \v counted as white space. Output matches GNU diff 3.12 for the cases in the issue (it also cuts in the middle of a UTF-8 character).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
binhvq added 3 commits November 11, 2026 14:36
@binhvq
diff: cut the -p/-F function line at 40 bytes and trim vertical tabs
8acb048 
The function line shown after a hunk header was limited to 40 characters, so a line of multi-byte characters came out up to four times longer than GNU's, which stops at 40 bytes. Vertical tabs around it were kept as well, because is_ascii_whitespace() leaves them out while C's isspace() does not.
@binhvq
Merge remote-tracking branch 'origin/main' into diff-function-line-bytes
9c29307
@binhvq
tests: port the function line tests to uutests
deabc86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

diff - -p/-F function line is cut at 40 characters, not bytes, and keeps a trailing \v

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@binhvq
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.