GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix and reformat installer by jeremy-audet · Pull Request #153 · vim-ruby/vim-ruby

Conversation

jeremy-audet commented May 9, 2013

Copy link

Copy Markdown

The first of these two commits fixes a deprecation issue which prevented the installer (bin/vim-ruby-installer.rb) from running sucessfully. The second commit simply reformats the file.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Jeremy Audet added 2 commits

May 9, 2013 10:13


          Fix deprecation error.

bea6026

Without fix, this error message appears:

    bin/vim-ruby-install.rb:15:in `<main>': Use RbConfig instead of obsolete and deprecated Config.

    uninitialized constant Env::CONFIG
    Try 'ruby bin/vim-ruby-install.rb --help' for detailed usage.


          Reformat installer.

f90d7b6

Replace tabs with spaces. Ensure comments are properly lined up with code.

AndrewRadev added a commit that referenced this pull request

Jun 1, 2013


          Merge pull request #153 from Ichimonji10/master

6ba4a63

fix and reformat installer

AndrewRadev merged commit 6ba4a63 into vim-ruby:master

Jun 1, 2013

AndrewRadev commented Jun 1, 2013

Copy link

Copy Markdown

Member

I see no harm in the pull request, though maybe it's time to remove the installer altogether. I don't have enough confidence to do that, though, so if any other maintainers know what the status of the installer is, maybe now would be a good time to consider it.

Thanks for your work, in any case.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jeremy-audet commented Jun 1, 2013

Copy link

Copy Markdown

Author

Yeah, I was surprised to see such a major issue in this package. If the installer flat-out fails, I suspect many people will not take this package seriously. No installer is better than a broken installer, IMO.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.