GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clarify description computation for aria-describedby by adampage · Pull Request #177 · w3c/accname

Conversation

@adampage

@adampage adampage commented Dec 6, 2022 •
edited by pr-preview Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #176.

Added editorial notes to 4.2 Description Computation.


Preview | Diff

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adampage
add note for aria-describedby self-referencing
c09fd41
@adampage adampage self-assigned this Dec 6, 2022
@adampage
adampage requested review from MelSumner and jnurthen December 6, 2022 21:02
@JAWS-test

JAWS-test commented Dec 7, 2022

Copy link
Copy Markdown

I suspect your change is wrong and has nothing to do with what was discussed:

  • your change, if I understand correctly, prohibits me from referring to the own element via aria-describedby. This should not be forbidden and was not so far
  • It was discussed that aria-description doesn't matter when referring to the element with aria-description via aria-describedby. The AccName and not the AccDesc of the element referenced by aria-describedby does matter (because aria-labelledby and aria-describedby work the same).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JAWS-test

JAWS-test commented Dec 7, 2022

Copy link
Copy Markdown

See https://www.w3.org/2022/11/10-aria-minutes#t07 and #69 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adampage added 2 commits December 7, 2022 15:44
@adampage
Revert "add note for aria-describedby self-referencing"
943fbe1
This reverts commit c09fd41.
@adampage
specify name computation for aria-describedby
2dbd039
@adampage

adampage commented Dec 8, 2022

Copy link
Copy Markdown
Member Author

I understand now. 🤦🏻‍♂️ Thank you for setting me straight, @JAWS-test. This is particularly embarrassing because I scribed that Nov 10 meeting. My brain was apparently not in attendance.

Assuming that I do actually understand now 😅, it seems like this simple replacement of “Text content computation” with the more specific “Name computation” would be sufficient?

JAWS-test reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adampage adampage changed the title Add note to clarify lack of support for self-referencing with aria-describedby Clarify description computation for aria-describedby Dec 8, 2022
@spectranaut
spectranaut requested a review from cookiecrook December 8, 2022 18:19
cookiecrook
cookiecrook reviewed Dec 8, 2022
View reviewed changes

@cookiecrook cookiecrook left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this also need to be changed in item 3 (Host language features) where the phrase "text equivalent computation" is used? It's not clear to me why this one would be specific to name comp, but the latter references T.E. comp.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cookiecrook

cookiecrook commented Dec 8, 2022

Copy link
Copy Markdown
Contributor

(E.g. line 247, just below this diff boundary)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MelSumner
MelSumner requested a review from accdc February 27, 2023 21:06
cookiecrook
cookiecrook requested changes Feb 28, 2023
View reviewed changes

@cookiecrook cookiecrook left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the answer is yes, so I'm changing my response from "Comment" to "Request Changes."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adampage reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
adampage added 2 commits February 28, 2023 16:00
@adampage
Merge branch 'main' into aria-describedby-selfref
88d4204
@adampage
specify name computation for host language features
0cfa4d6
@adampage

adampage commented Mar 1, 2023

Copy link
Copy Markdown
Member Author

I think the answer is yes, so I'm changing my response from "Comment" to "Request Changes."

Done. Thanks, @cookiecrook.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

accdc
accdc approved these changes Mar 1, 2023
View reviewed changes
MelSumner
MelSumner approved these changes Mar 2, 2023
View reviewed changes

@MelSumner MelSumner left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MelSumner
MelSumner requested a review from cookiecrook March 2, 2023 18:18
cookiecrook
cookiecrook requested changes Mar 3, 2023
View reviewed changes
Comment thread index.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

@accdc

accdc commented Apr 14, 2023

Copy link
Copy Markdown
Contributor

Hi, I've been rereading this issue and am confused because it seems to flip back and forth. Is the purpose to prevent self-referencing by aria-describedby but not for aria-labelledby?

I have seen this used successfully on tables that have checkbox or radio button controls that will reference the parent row using aria-describedby to announce the full content of the row being selected when the screen reader is interacting with it, and this is quite helpful.

Would this change prevent something like this from working?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cookiecrook

cookiecrook commented May 8, 2023

Copy link
Copy Markdown
Contributor

@accdc wrote:

Hi, I've been rereading this issue and am confused because it seems to flip back and forth. Is the purpose to prevent self-referencing by aria-describedby but not for aria-labelledby?

I have seen this used successfully on tables that have checkbox or radio button controls that will reference the parent row using aria-describedby to announce the full content of the row being selected when the screen reader is interacting with it, and this is quite helpful.

Would this change prevent something like this from working?

If you're referring to the note @jnurthen and I were discussing in the thread, no, it won't prevent anything from working. It's just informative authoring guidance.

If "this change" is referring to something else, I would need a more specific reference.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

adampage and others added 3 commits July 10, 2023 23:51
@adampage @cookiecrook
Update index.html
44b1b46
Co-authored-by: James Craig <[email protected]>
@adampage
Merge branch 'main' into aria-describedby-selfref
7a77714
@adampage
Fix typo
28d1873
@adampage

adampage commented Jul 11, 2023

Copy link
Copy Markdown
Member Author

I’m inclined to limit this PR to clarifying that aria-describedby’s computation should only gather the accessible name(s) of the referenced node(s), not their accessible descriptions. I’m to blame for misinterpreting the original consensus to begin with. 😣 If we think there’s merit to discouraging a node from describing itself, how about tackling that as a separate issue?

In the meantime, I’ve committed your suggested reversion, @cookiecrook. I also created a quick Codepen to examine aria-labelledby, aria-label, aria-describedby, and aria-description, in case it could be helpful in follow-up discussions.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adampage
adampage requested a review from cookiecrook July 11, 2023 04:55
cookiecrook
cookiecrook approved these changes Jul 27, 2023
View reviewed changes

@cookiecrook cookiecrook left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay to me

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@adampage

adampage commented Jul 27, 2023

Copy link
Copy Markdown
Member Author

Thanks very much, @cookiecrook. I believe this is ready for merge, @spectranaut / @jnurthen / @pkra?

MelSumner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MelSumner
MelSumner merged commit 881d960 into main Jul 27, 2023
github-actions Bot added a commit that referenced this pull request Jul 27, 2023
@adampage @github-actions
Clarify description computation for aria-describedby (#177)
9fc732b
SHA: 881d960
Reason: push, by MelSumner

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cookiecrook cookiecrook cookiecrook approved these changes
@accdc accdc accdc approved these changes
@MelSumner MelSumner MelSumner approved these changes
@jnurthen jnurthen Awaiting requested review from jnurthen

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@adampage adampage

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clarify: should aria-description be able to self-reference like aria-labelledby?

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@adampage @JAWS-test @cookiecrook @accdc @jnurthen @MelSumner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.