GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use CMake features to find NumPy by HunterBelanger · Pull Request #333 · xtensor-stack/xtensor-python

Conversation

@HunterBelanger

@HunterBelanger HunterBelanger commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

The current CMake script that is used to find NumPy does not always work for me, and sometimes causes problems on the different systems I build on. Given we have recently updated the minimum CMake version and the minimum pybind11 version, these changes now use the standard CMake tools to find Python3 and NumPy, and makes the links with the standard CMake targets. I specifically use Python3 in the CMake as the indicated pybind11 version no longer supports Python 2.7.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@HunterBelanger

HunterBelanger commented Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

I know it has taken me a bit to figure out the exact linking needed for the tests, but now, the current test failures seem to be due to the test environment not having the libpython3.so available:

CMake Error at /home/runner/micromamba/envs/xtensor-python/share/cmake-4.4/Modules/FindPackageHandleStandardArgs.cmake:290 (message):
  Could NOT find Python3 (missing: Python3_LIBRARIES Development.Embed)
  (found version "3.15.0")

Looking at this link, it appears that starting with Python 3.15, the python package in conda no longer provides libpython3.so, and you must add the libpython package as well. The error message seems to support this, as it found a 3.15 interpreter, but not the dynamic library. I don't think any tests have been run on this repo since python 3.15 came out ? Because I think if the pipeline on master were to be re-run, you would find that tests are broken due to this issue. To fix this, I am going to just specify python and libpython as dependencies in environment-dev.yml to try and fix the problem.

JohanMabille reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JohanMabille

JohanMabille commented Oct 17, 2026

Copy link
Copy Markdown
Member

I don't think any tests have been run on this repo since python 3.15 came out ?

I don't think so.

Also do you want to open another PR with a very small change that I can merge, so that you don't need to wait for approval to run the CI in this one?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@HunterBelanger

HunterBelanger commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

Yes, that is a good idea. In any case, it was clear that python and libpython need to be added to the test environment for the build to work now. I will put those in a separate PR while trying to fix the remaining issues with this one.

JohanMabille reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@HunterBelanger HunterBelanger mentioned this pull request Oct 18, 2026
Fix test environment #334
Merged
JohanMabille pushed a commit that referenced this pull request Oct 19, 2026
@HunterBelanger
Fix test environment (#334)
74f1160
As mentioned in #333, the test environment is currently broken due to
conda packaging changes for Python starting with version 3.15 which just
came out. This explicitly adds both `python` and `libpython` to the test
environment so that the text executables can be built.
HunterBelanger added 4 commits October 19, 2026 18:19
@HunterBelanger
Use built in cmake features to find NumPy
9061365
@HunterBelanger
Remove now obsolete link to python lib
6c6ea06
@HunterBelanger
Embed python for text exe
6598f7d
@HunterBelanger
Fix examples tests
8750602
@HunterBelanger
HunterBelanger force-pushed the fix/numpy branch from 9d62a28 to 8750602 Compare October 19, 2026 16:24
JohanMabille
JohanMabille approved these changes Oct 20, 2026
View reviewed changes

@JohanMabille JohanMabille left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@JohanMabille
JohanMabille merged commit 12b79a0 into xtensor-stack:master Oct 20, 2026
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@HunterBelanger @JohanMabille
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.