GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Edit Task
  • Edit Related Tasks...
  • Create Subtask
  • Edit Parent Tasks
  • Edit Subtasks
  • Merge Duplicates In
  • Close As Duplicate
  • Edit Commits
  • Edit Mocks
  • Mute Notifications
  • Protect as security issue
  • Pywikibot
  • (Needs Review)
  • Pywikibot-Scripts

This view

  • Original page
  • New address

GeezerVison is showing phabricator.wikimedia.org — T184033 download_dump.py: Move the file location from `scripts/maintenance` to `scripts`

Page MenuHomePhabricator
Log In
Create Task
Maniphest T184033

download_dump.py: Move the file location from `scripts/maintenance` to `scripts`
Closed, ResolvedPublic
Actions

  • Edit Task
  • Edit Related Tasks...
  • Create Subtask
  • Edit Parent Tasks
  • Edit Subtasks
  • Merge Duplicates In
  • Close As Duplicate
  • Edit Related Objects...
  • Edit Commits
  • Edit Mocks
  • Mute Notifications
  • Protect as security issue
Assigned To
rafidaslam
Authored By
rafidaslam
Jan 3 2018, 4:30 AM2018-01-03 04:30:59 (UTC+0)
Project Tags
  • Pywikibot (Needs Review)
  • Pywikibot-Scripts (Backlog)
Referenced Files
None
Subscribers
Aklapper
eflyjason
Framawiki
gerritbot
jayvdb
pywikibot-bugs-list
rafidaslam
View All 9 Subscribers

Description

As stated in https://gerrit.wikimedia.org/r/#/c/401377/4/scripts/maintenance/download_dump.py@49 and in https://phabricator.wikimedia.org/T123885 , the download_dump.py isn't meant to be a maintenance script, it should be placed in the scripts directory.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
download_dump: Move the file to `scripts`Rafidaslampywikibot/coremaster+5 -4
Customize query in gerrit

Related Objects
Search...

  • Task Graph
  • Mentions
StatusSubtypeAssignedTask
 OpenNoneT183663 Improve the maintenance script that download Wikimedia database dump
 ResolvedrafidaslamT184033 download_dump.py: Move the file location from `scripts/maintenance` to `scripts`
Mentioned In
rPWBCdc88b068cb98: download_dump: Move the file to `scripts`

Event Timeline

rafidaslam created this task.Jan 3 2018, 4:30 AM2018-01-03 04:30:59 (UTC+0)
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJan 3 2018, 4:30 AM2018-01-03 04:30:59 (UTC+0)
rafidaslam triaged this task as Medium priority.Jan 3 2018, 4:32 AM2018-01-03 04:32:05 (UTC+0)
gerritbot subscribed.Jan 3 2018, 5:44 AM2018-01-03 05:44:27 (UTC+0)
Comment Actions

Change 401674 had a related patch set uploaded (by Rafidaslam; owner: rafid):
[pywikibot/core@master] download_dump: Move the file to scripts

https://gerrit.wikimedia.org/r/401674

gerritbot added a project: Patch-For-Review.Jan 3 2018, 5:44 AM2018-01-03 05:44:27 (UTC+0)
zhuyifei1999 subscribed.Jan 3 2018, 5:54 AM2018-01-03 05:54:07 (UTC+0)
Comment Actions

See also @Framawiki's comment on PS7 of https://gerrit.wikimedia.org/r/#/c/399179/

zhuyifei1999 added a parent task: T183663: Improve the maintenance script that download Wikimedia database dump.Jan 3 2018, 6:03 AM2018-01-03 06:03:29 (UTC+0)
jayvdb subscribed.Jan 3 2018, 8:31 AM2018-01-03 08:31:52 (UTC+0)
Comment Actions

This was done at my request during code review because this script wasnt being tested with tests/script_tests.py which it should be.

This script is not a maintenance script. maintenance scripts are not tested, because they are used for scripts used to maintain pywikibot only.

scripts has a wide variety of contents, including tools which dont do anything, like version & shell, and scripts which only work on wikimedia sites, like all of the Wikidata specific scripts. Those are not reasons to put it under a different directory.
If anyone is insisting that it must be under maintenance, then they must improve the test framework to test maintenance scripts also.
Otherwise I turn off all pywikibot GCI tasks related to this script because they are bypassing the test suite as it exists.

jayvdb added a subscriber: Xqt.Jan 3 2018, 8:32 AM2018-01-03 08:32:30 (UTC+0)
eflyjason subscribed.Jan 4 2018, 11:03 AM2018-01-04 11:03:49 (UTC+0)
xSavitar moved this task from Backlog to Needs Review on the Pywikibot board.Nov 5 2018, 11:27 AM2018-11-05 11:27:32 (UTC+0)
Xqt closed this task as Resolved.Aug 6 2020, 4:59 PM2020-08-06 16:59:38 (UTC+0)
gerritbot added a comment.Aug 6 2020, 5:01 PM2020-08-06 17:01:38 (UTC+0)
Comment Actions

Change 401674 merged by jenkins-bot:
[pywikibot/core@master] download_dump: Move the file to scripts

https://gerrit.wikimedia.org/r/401674

Xqt mentioned this in rPWBCdc88b068cb98: download_dump: Move the file to `scripts`.Aug 6 2020, 5:03 PM2020-08-06 17:03:34 (UTC+0)
Maintenance_bot removed a project: Patch-For-Review.Aug 6 2020, 5:10 PM2020-08-06 17:10:42 (UTC+0)
Log In to Comment
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.