GeezerVison is showing github.com — Make jdk.jfr import optional in OSGi manifest by laeubi · Pull Request #5092 · junit-team/junit-framework
Conversation
laeubi
commented
Oct 25, 2025
•
edited by marcphilipp
Loading
Uh oh!
There was an error while loading. Please reload this page.
With the recent adoption of JUnit 6 we noticed that JUnit no longer can run on stripped down JVMs that are missing the flight recorder module because it has a mandatory import in the OSGi manifest.
As the flightrecorder integration seems optional, one might want to make the import of the package optional as well
I hereby agree to the terms of the JUnit Contributor License Agreement.
The content was generated by copilote here I squashed the commits, reviewed the result and found it being sane compared to how it was done for other optional imports. Please let me know if any adjustments are necessary as I'm not familiar with gradle.
Definition of Done
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think it's good to make this consistent with the module descriptor. Please note that we might make it mandatory in the future at which point the JDK used needs to include the jdk.jfr module or add jfr-polyfill to their classpath.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
Import-Package: \
|
|
|
${importAPIGuardian},\
|
|
|
${importJSpecify},\
|
|
|
${importJdkJfr},\
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move these changes to the build script of junit-platform-launcher as they're specific to that module/bundle (see junit-platform-commons for an example).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcphilipp I'm sadly not very familiar with gradle build scripts and looking at that build-script I'm not completely sure how to archive this, as that one adds an additional header and here we want to modify an existing definition. I could repeat the definition there but it seems a bit odd to maintain then.
Any suggestion?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I pushed a few commits. I agree that modifying an existing definition is not as DRY as one would wish.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
chrisrueger reacted with thumbs up emoji
|
Cherry-picked to releases/6.0.x in fedda88
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Ogu1208
pushed a commit
to Ogu1208/junit-framework
that referenced
this pull request
Dec 11, 2025
mergify Bot
added a commit
to ArcadeData/arcadedb
that referenced
this pull request
May 24, 2026
mergify Bot
added a commit
to robfrank/amphora
that referenced
this pull request
Jun 2, 2026
mergify Bot
added a commit
to robfrank/linklift
that referenced
this pull request
Jun 4, 2026
tae898
pushed a commit
to humemai/arcadedb-embedded-python
that referenced
this pull request
Jun 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|