GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix Refinement Declaration Positions by rcosta358 · Pull Request #287 · liquid-java/liquidjava

Conversation

@rcosta358

@rcosta358 rcosta358 commented Aug 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Description

This PR fixes the declaration positions of refinement and state refinement errors to target the exact refinement location instead of the target element. Follow-up of #285.

Example

Before

image

After

image

Related Issue

None.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Checklist

  • Added/updated tests
  • mvn test passes locally
  • Updated docs/README if behavior or API changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rcosta358
Fix Refinement Declaration Positions
83681ad
@rcosta358 rcosta358 self-assigned this Aug 25, 2026
@rcosta358 rcosta358 added the error messages Related to error messages label Aug 25, 2026
@rcosta358
rcosta358 requested a review from CatarinaGamboa August 25, 2026 12:35
rcosta358 added 2 commits August 25, 2026 13:56
@rcosta358
Exclude Quotes
c8dc18f
@rcosta358
Add New Line
90e3e52
alcides
alcides approved these changes Sep 12, 2026
View reviewed changes
@rcosta358
rcosta358 merged commit 88d0d9e into main Sep 12, 2026
1 check passed

Uh oh!

There was an error while loading. Please reload this page.
@rcosta358
rcosta358 deleted the fix-ref-decl-positions branch September 12, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alcides alcides alcides approved these changes
@CatarinaGamboa CatarinaGamboa Awaiting requested review from CatarinaGamboa

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rcosta358 rcosta358

Labels

error messages Related to error messages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rcosta358 @alcides
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.