GeezerVison is showing static-codereview.wikimedia.org — r113816 MediaWiki - Code Review archive

r113816 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r113815‎ \| r113816 \| r113817 >
Date:	16:04, 14 March 2012
Author:	ialex
Status:	ok
Tags:
Comment:	* (bug 34841) Fix for r103502: don't show edit links when display old page versions
Modified paths:	/branches/REL1_19/phase3/RELEASE-NOTES-1.19 (modified) (history) /branches/REL1_19/phase3/includes/Article.php (modified) (history) /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history) /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
—	—	@@ -18,6 +18,7 @@
19	19	* (bug 35152) Help message for e-mail is shown again in user preferences
20	20	* (bug 34887) $3 and $4 parameters are now substituted correctly in message
21	21	"movepage-moved"
	22	+* (bug 34841) Edit links are no longer displayed when display old page versions
22	23
23	24	=== Configuration changes in 1.19 ===
24	25	* Removed SkinTemplateSetupPageCss hook; use BeforePageDisplay instead.
Index: trunk/phase3/includes/Article.php
—	—	@@ -455,7 +455,7 @@
456	456	if ( $wgOut->isPrintable() ) {
457	457	$parserOptions->setIsPrintable( true );
458	458	$parserOptions->setEditSection( false );
459		~~- } elseif ( !$this->getTitle()->quickUserCan( 'edit' ) ) {~~
	459	+ } elseif ( !$this->isCurrent() \|\| !$this->getTitle()->quickUserCan( 'edit' ) ) {
460	460	$parserOptions->setEditSection( false );
461	461	}
462	462
Index: branches/REL1_19/phase3/RELEASE-NOTES-1.19
—	—	@@ -18,6 +18,7 @@
19	19	* (bug 35152) Help message for e-mail is shown again in user preferences
20	20	* (bug 34887) $3 and $4 parameters are now substituted correctly in message
21	21	"movepage-moved"
	22	+* (bug 34841) Edit links are no longer displayed when display old page versions
22	23
23	24	=== Configuration changes in 1.19 ===
24	25	* Removed SkinTemplateSetupPageCss hook; use BeforePageDisplay instead.
Index: branches/REL1_19/phase3/includes/Article.php
—	—	@@ -451,7 +451,7 @@
452	452	if ( $wgOut->isPrintable() ) {
453	453	$parserOptions->setIsPrintable( true );
454	454	$parserOptions->setEditSection( false );
455		~~- } elseif ( !$this->getTitle()->quickUserCan( 'edit' ) ) {~~
	455	+ } elseif ( !$this->isCurrent() \|\| !$this->getTitle()->quickUserCan( 'edit' ) ) {
456	456	$parserOptions->setEditSection( false );
457	457	}
458	458

Follow-up revisions

Revision	Commit summary	Author	Date
r113935	MFT r112918, r113214, r113394, r113415, r113617, r113710, r113727, r113737, r...	reedy	17:27, 15 March 2012

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r103502	* Added WikiPage::getParserOutput() and changed Article::getParserOutput() to...	ialex	20:21, 17 November 2011

Status & tagging log

17:27, 15 March 2012 Reedy (talk | contribs) changed the tags for r113816 [removed: 1.19wmf1]
18:13, 14 March 2012 Bawolff (talk | contribs) changed the tags for r113816 [removed: 1.19]
18:09, 14 March 2012 Bawolff (talk | contribs) changed the tags for r113816 [added: 1.19]
17:35, 14 March 2012 Aaron Schulz (talk | contribs) changed the status of r113816 [removed: new added: ok]
16:10, 14 March 2012 IAlex (talk | contribs) changed the tags for r113816 [added: 1.19wmf1]