GeezerVison is showing static-codereview.wikimedia.org — r82081 MediaWiki - Code Review archive
r82081 MediaWiki - Code Review archive
| Repository: | MediaWiki |
| Revision: | < r82080 | r82081 | r82082 > |
| Date: | 21:20, 13 February 2011 |
| Author: | brion |
| Status: | ok (Comments)
|
| Tags: | |
| Comment: | * ( bug 27377) Fix Special:Listfile user selector when initial form parameters already set
Follow-up to r68096: fix field name when blacklisting for hidden fields.
The user field ended up getting copied into the hidden fields due to wrong name in the getHiddenFields() call. |
| Modified paths: |
- /trunk/phase3/includes/specials/SpecialListfiles.php (modified) (history)
|
| Index: trunk/phase3/includes/specials/SpecialListfiles.php |
| — | — | @@ -213,7 +213,7 @@ |
| 214 | 214 | Xml::fieldset( wfMsg( 'listfiles' ) ) . |
| 215 | 215 | Html::openElement( 'table', array( 'id' => 'mw-listfiles-table' ) ) . |
| 216 | 216 | Xml::buildForm( $inputForm, 'table_pager_limit_submit' ) . |
| 217 | | - $this->getHiddenFields( array( 'limit', 'ilsearch', 'username' ) ) . |
| | 217 | + $this->getHiddenFields( array( 'limit', 'ilsearch', 'user' ) ) . |
| 218 | 218 | Html::closeElement( 'table' ) . |
| 219 | 219 | Html::closeElement( 'fieldset' ) . |
| 220 | 220 | Html::closeElement( 'form' ) . "\n"; |
Follow-up revisions
| Revision | Commit summary | Author | Date |
|---|
| r82151 | 1.17wmf1: MFT r78964, r79086, r79087, r79091, r82004, r82025, r82048, r82070,... | catrope | 22:55, 14 February 2011 |
| r85151 | MFT: r82000, r82004, r82020, r82025, r82038, r82039, r82048, r82070, r82081, ... | demon | 20:39, 1 April 2011 |
Past revisions this follows-up on
| Revision | Commit summary | Author | Date |
|---|
| r68096 | Follow-up r65013: Add an input field for the username. Use the nice Xml::buil... | raymond | 18:16, 15 June 2010 |
Comments
Status & tagging log
- 20:40, 1 April 2011 😂 (talk | contribs) changed the tags for r82081 [removed: 1.17]
- 19:23, 15 February 2011 Krinkle (talk | contribs) changed the tags for r82081 [removed: 1.17wmf1]
- 21:47, 13 February 2011 Bryan (talk | contribs) changed the tags for r82081 [added: 1.17wmf1]
- 21:47, 13 February 2011 Bryan (talk | contribs) changed the status of r82081 [removed: new added: ok]
- 21:21, 13 February 2011 Brion VIBBER (talk | contribs) changed the tags for r82081 [added: 1.17]
|