GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — Fix nrf sdk download links by dariusarnold · Pull Request #2270 · InfiniTimeOrg/InfiniTime Conversation
Contributor
It appears that NRF has moved the download to a new location. The old URL is now a 404. Fixes #2267
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsIt seems like NRF has moved the download to a new location- Update the build script to fetch from the same URL the download website currently provides.
|
There was an error while loading. Please reload this page.
|
Build size and comparison to main:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@dariusarnold Do you know if those URLs are still hosted by Nordic and if they are "official"? The domain name does not seem to be directly linked to Nordic Semiconductor. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
It's official, you can find them on the nordic website See here https://www.nordicsemi.com/Products/Development-software/nRF5-SDK/Download#infotabs |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh yes, right! I previously clicked on the big "Download files (.zip)" button and did not notice that I could simply click on the name of the package! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
The upstream NRF-SDK download url and zip archive filename changed, which was fixed with #2270 But the archive contents stayed the same, with the "old" folder name. After #2270 we have basically the same docker-container as before the PR, but the `GetNrfSdk` function of the `build.sh` script is called again during firmware build time as the expected foldername for the SDK isn't the same as the zip filename: ```sh [ ! -d "$TOOLS_DIR/$NRF_SDK_VER" ] && GetNrfSdk ``` Then during the build the `buils.sh` script tries to execute `GetNrfSdk` again, which fails as the files already exist resulting in the following error: ``` replace /opt/nRF5_SDK_15.3.0_59ac345/components/802_15_4/api/HAL/hal_atomic.h? [y]es, [n]o, [A]ll, [N]one, [r]ename: NULL ``` Fix this by reverting the `NRF_SDK_VER` to the folder name in the zip archive and by some character replacement generate the download URL from the above (the download is in lower-case without the `_` and `.` characters). Furthermore add safeguards to check after the `GetNrfSdk` call if the expected folder is really created. Then we have an error early during container image creation if the contents of the zip-archive are unexpected.
The upstream NRF-SDK download url and zip archive filename changed, which was fixed with #2270 But the archive contents stayed the same, with the "old" folder name. After #2270 we have basically the same docker-container as before the PR, but the `GetNrfSdk` function of the `build.sh` script is called again during firmware build time as the expected foldername for the SDK isn't the same as the zip filename: ```sh [ ! -d "$TOOLS_DIR/$NRF_SDK_VER" ] && GetNrfSdk ``` Then during the build the `buils.sh` script tries to execute `GetNrfSdk` again, which fails as the files already exist resulting in the following error: ``` replace /opt/nRF5_SDK_15.3.0_59ac345/components/802_15_4/api/HAL/hal_atomic.h? [y]es, [n]o, [A]ll, [N]one, [r]ename: NULL ``` Fix this by reverting the `NRF_SDK_VER` to the folder name in the zip archive and by some character replacement generate the download URL from the above (the download is in lower-case without the `_` and `.` characters). Furthermore add safeguards to check after the `GetNrfSdk` call if the expected folder is really created. Then we have an error early during container image creation if the contents of the zip-archive are unexpected.
nRF has moved the download to a new location- Update the build script to fetch from the same URL the download website currently provides.
) The upstream NRF-SDK download url and zip archive filename changed, which was fixed with InfiniTimeOrg#2270 But the archive contents stayed the same, with the "old" folder name. After InfiniTimeOrg#2270 we have basically the same docker-container as before the PR, but the `GetNrfSdk` function of the `build.sh` script is called again during firmware build time as the expected foldername for the SDK isn't the same as the zip filename: ```sh [ ! -d "$TOOLS_DIR/$NRF_SDK_VER" ] && GetNrfSdk ``` Then during the build the `buils.sh` script tries to execute `GetNrfSdk` again, which fails as the files already exist resulting in the following error: ``` replace /opt/nRF5_SDK_15.3.0_59ac345/components/802_15_4/api/HAL/hal_atomic.h? [y]es, [n]o, [A]ll, [N]one, [r]ename: NULL ``` Fix this by reverting the `NRF_SDK_VER` to the folder name in the zip archive and by some character replacement generate the download URL from the above (the download is in lower-case without the `_` and `.` characters). Furthermore add safeguards to check after the `GetNrfSdk` call if the expected folder is really created. Then we have an error early during container image creation if the contents of the zip-archive are unexpected.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Docker build broken because NRF SDK changed download location
There was an error while loading. Please reload this page.